From owner-freebsd-ports@FreeBSD.ORG  Sat Jul 28 12:36:36 2007
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 999AD16A417
	for <freebsd-ports@freebsd.org>; Sat, 28 Jul 2007 12:36:36 +0000 (UTC)
	(envelope-from me@janh.de)
Received: from moutng.kundenserver.de (moutng.kundenserver.de
	[212.227.126.186])
	by mx1.freebsd.org (Postfix) with ESMTP id 461BF13C428
	for <freebsd-ports@freebsd.org>; Sat, 28 Jul 2007 12:36:36 +0000 (UTC)
	(envelope-from me@janh.de)
Received: from [80.171.115.154] (helo=janh.freebsd)
	by mrelayeu.kundenserver.de (node=mrelayeu8) with ESMTP (Nemesis),
	id 0ML31I-1IElWe1x86-00040p; Sat, 28 Jul 2007 14:36:34 +0200
Message-ID: <46AB3831.60301@janh.de>
Date: Sat, 28 Jul 2007 14:36:01 +0200
From: Jan Henrik Sylvester <me@janh.de>
User-Agent: Thunderbird 2.0.0.5 (X11/20070720)
MIME-Version: 1.0
To: freebsd-ports@freebsd.org
References: 46AB1480.6000602@janh.de
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Provags-ID: V01U2FsdGVkX1+HNUlxB8BI4RYCyKoVAZ2lORne4RrTB3tpvT2
	L6kt3xb+pwJU9DYQncRToEa6WDn3rtcN9Lf0KSLuNN4XiExGj2
	9K+2sAmWeirzU5g+u12sw==
Cc: ade@freebsd.org
Subject: failure: portupgrade -f 'autoconf*' 'automake*'
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Jul 2007 12:36:36 -0000

Ade wrote:
 > On Jul 28, 2007, at 03:03 , Jan Henrik Sylvester wrote:
 > > I think, there should be a '-' in front of every ${BUILD_VERSION}.
 > >
 > > Additionally to the one at --program-suffix, there are three more
 > > missing.
 >
 > The appropriate fix has already been committed.  Given the very small
 > window of things being broken, I'm not planning on bumping PORTREVISION.

You only fixed the --program-suffix=-${BUILD_VERSION}.

Was I wrong that in contrast to 259, in 261 there should not be a '-' in 
front of the 3 ${BUILD_VERSION} in post-patch?

 From 259 (rev=1.65):
post-patch:
	@(cd ${WRKSRC} && ${REINPLACE_CMD} -E 
's,(PACKAGE=autoconf),\1-${BUILD_VERSION},' configure)
	@(cd ${WRKSRC}/man && \
		for file in *.[1x]; do \
			${REINPLACE_CMD} -E 
's,([^-]auto)(conf|make|reconf|update|header|scan),\1\2-${BUILD_VERSION},g 
; \
						s,(config\.guess|config\.sub|ifnames),\1-${BUILD_VERSION},g' 
$$file ; \
		done)

 From 261 (rev=1.69):
post-patch:
	@(cd ${WRKSRC} && ${REINPLACE_CMD} -E 
's,(PACKAGE=autoconf),\1${BUILD_VERSION},' configure)
	@(cd ${WRKSRC}/man && \
		for file in *.[1x]; do \
			${REINPLACE_CMD} -E 
's,([^-]auto)(conf|make|reconf|update|header|scan),\1\2${BUILD_VERSION},g 
; \
						s,(config\.guess|config\.sub|ifnames),\1${BUILD_VERSION},g' $$file ; \
		done)

Just wondering,
Jan Henrik