From owner-freebsd-current Sat Jan 27 13: 6:24 2001 Delivered-To: freebsd-current@freebsd.org Received: from magnesium.net (toxic.magnesium.net [207.154.84.15]) by hub.freebsd.org (Postfix) with SMTP id 1829C37B401 for ; Sat, 27 Jan 2001 13:06:06 -0800 (PST) Received: (qmail 93304 invoked by uid 1142); 27 Jan 2001 21:06:04 -0000 Date: 27 Jan 2001 13:06:04 -0800 Date: Sat, 27 Jan 2001 13:05:58 -0800 From: Jason Evans To: Matthew Jacob Cc: jlemon@freebsd.org, freebsd-current@FreeBSD.ORG Subject: Re: XXX driver didn't initialize queue mtx Message-ID: <20010127130558.P87569@canonware.com> References: <20010127124149.O87569@canonware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from mjacob@feral.com on Sat, Jan 27, 2001 at 12:48:36PM -0800 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, Jan 27, 2001 at 12:48:36PM -0800, Matthew Jacob wrote: > Somewhere in between, Jason Evans wrote: > > On Sat, Jan 27, 2001 at 12:36:41PM -0800, Matthew Jacob wrote: > > > > > > Oh, I suppose, I did find that... well, mainly I wanted the person who made > > > the change to actually broadcast to NIC maintainers what the expectations > > > were... > > > > The code that prints these warnings out has existed for a while. However, > > whoever added it made a bad assumption about the internals of the mutex > > implementation, so the code never got executed. I "fixed" it last week, so > > the warnings get printed now. > > Shouldn't ether_ifattach initialize the mutex? Or do expect all drivers to > initialize these prior to calling ether_ifattach? > > Look- I just want to know what the people who put the check in *want*..... cvs annotate is your friend. The code was added in revision 1.95 of src/sys/net/if.c by Jonathan Lemon. Please talk to him about what should be done to fix the drivers. Jason To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message