From owner-cvs-all@FreeBSD.ORG Tue Mar 8 01:29:39 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5CA3616A4CE; Tue, 8 Mar 2005 01:29:39 +0000 (GMT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3815643D60; Tue, 8 Mar 2005 01:29:39 +0000 (GMT) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 32EBE5C992; Mon, 7 Mar 2005 17:29:39 -0800 (PST) Date: Mon, 7 Mar 2005 17:29:39 -0800 From: Alfred Perlstein To: Maxim Sobolev Message-ID: <20050308012939.GP11079@elvis.mu.org> References: <200503070726.j277Qhp5059059@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200503070726.j277Qhp5059059@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linux linux_socket.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2005 01:29:39 -0000 Why not just expand our API to do this as well? It shouldn't be that hard and then we'll gain the additional functionality. * Maxim Sobolev [050306 23:26] wrote: > sobomax 2005-03-07 07:26:43 UTC > > FreeBSD src repository > > Modified files: > sys/compat/linux linux_socket.c > Log: > Handle MSG_NOSIGNAL flag in linux_send() by setting SO_NOSIGPIPE on socket > for the duration of the send() call. Such approach may be less than ideal > in threading environment, when several threads share the same socket and it > might happen that several of them are calling linux_send() at the same time > with and without SO_NOSIGPIPE set. > > However, such race condition is very unlikely in practice, therefore this > change provides practical improvement compared to the previous behaviour. > > PR: kern/76426 > Submitted by: Steven Hartland > MFC after: 3 days > > Revision Changes Path > 1.56 +25 -2 src/sys/compat/linux/linux_socket.c -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684