Date: Sun, 23 Jun 2024 09:31:35 +0800 From: Zhenlei Huang <zlei@FreeBSD.org> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: FreeBSD Net <freebsd-net@freebsd.org> Subject: Re: ifp gone in ip6_output() -> panic Message-ID: <F4A7AC7B-30B1-4AF2-B814-0BB7C723042F@FreeBSD.org> In-Reply-To: <osr75qr9-3r79-9608-6312-119336173452@yvfgf.mnoonqbm.arg> References: <1p003r05-684o-8542-r153-n850s3sspnp3@yvfgf.mnoonqbm.arg> <F19D9E47-CB88-4CE0-BD52-DB1F33435FBF@FreeBSD.org> <osr75qr9-3r79-9608-6312-119336173452@yvfgf.mnoonqbm.arg>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On May 24, 2024, at 6:12 AM, Bjoern A. Zeeb <bzeeb-lists@lists.zabbadoz.net> wrote: > > On Wed, 22 May 2024, Zhenlei Huang wrote: > >> >> >>> On May 22, 2024, at 12:17 PM, Bjoern A. Zeeb <bzeeb-lists@lists.zabbadoz.net> wrote: >>> >>> Hi, >>> >>> sorry, I cannot dump; this is a diskless and netdump does not do IPv6; >>> needless to say that would be funny in this case anyway; unfortunately >>> I have also already re-compiled the kernel so I can only look things up approx. >>> >>> FreeBSD main from May 13 (f3eeeb959c9b00c89a2e1ff009c78162eb398656). >>> >>> I assume we lost the ifp from a destroy of a cloned interface in ip6_output() >>> between lines 806 and 811? >>> >>> >>> Kernel page fault with the following non-sleepable locks held: >>> exclusive rw rawinp (rawinp) r = 0 (0xfffff80002a6e1a0) locked @ /usr/src/sys/netinet6/raw_ip6.c:393 >>> stack backtrace: >>> #0 0xffffffff80bb679c at witness_debugger+0x6c >>> #1 0xffffffff80bb7979 at witness_warn+0x3e9 >>> #2 0xffffffff81061d10 at trap_pfault+0x80 >>> #3 0xffffffff81033878 at calltrap+0x8 >>> #4 0xffffffff80d99228 at rip6_send+0x5a8 >>> #5 0xffffffff80bf570e at sosend_generic+0x5ee >>> #6 0xffffffff80bf5c49 at sousrsend+0x79 >>> #7 0xffffffff80bfbd5c at kern_sendit+0x1bc >>> #8 0xffffffff80bfc073 at sendit+0x1b3 >>> #9 0xffffffff80bfc1ab at sys_sendmsg+0x5b >>> #10 0xffffffff81062638 at amd64_syscall+0x158 >>> #11 0xffffffff8103418b at fast_syscall_common+0xf8 >>> Created wlan(4) interfaces: wlan >> >> Note the creation of wlan, and a following ICMP6 (ping6) packet. > > Yes I think it was running netif restart wlan0 in loops. > > > [...] >> >> I'm not quite sure, but it seems the `ifp` is not fully constructed. See https://cgit.freebsd.org/src/tree/sys/net/if.c#n950 <https://cgit.freebsd.org/src/tree/sys/net/if.c#n950><https://cgit.freebsd.org/src/tree/sys/net/if.c#n950 <https://cgit.freebsd.org/src/tree/sys/net/if.c#n950>>; >> >> If I read the code correctly, the clone created interface is made visible via `if_link_ifnet(ifp);` , and at that time the >> `ifp->if_afdata[AF_INET6]` is NULL and is not initialized yet by `if_attachdomain1()` which will call `in6_domifattach()` >> to allocate the required data. >> >> So I guess there is a race condition. I bet this can be repeated easily. >> >> I have not tested this yet, and not sure if it is the right fix, but you can give it a try. > > I'll do; I haven't seen the error happening since on other test > machines, so not sure about repeatability. > > I am also not entirely sure this is not a ping6 ff02::1%wlan0 while > the ifp was destroyed by netif restart at the same time the packet was > still on the way out? I think that is possible. There is another report https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279653 <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279653>; but with a different fault path. > > If it was during create, the wlan(4) interface would not be associated > and UP at that point of if_attach_internal() and > `ifconfig inet6 -ifdisabled` would not have been run to be able to send > that packet in first place? Emm, I'm still hacking the lifecycle of ifnet. I think you're right. By default inet6 is disabled on interfaces. It seems to be impossible to send packets via disabled interfaces. > > Othwerwise the packet would have had to "survive" the clone destroy and > clone create cycle somewhere ...? > > >> diff --git a/sys/net/if.c b/sys/net/if.c >> index c3c27fbf678f..16ee5667e7bb 100644 >> --- a/sys/net/if.c >> +++ b/sys/net/if.c >> @@ -947,11 +947,11 @@ if_attach_internal(struct ifnet *ifp, bool vmove) >> } >> #endif >> >> - if_link_ifnet(ifp); >> - >> if (domain_init_status >= 2) >> if_attachdomain1(ifp); >> >> + if_link_ifnet(ifp); >> + >> EVENTHANDLER_INVOKE(ifnet_arrival_event, ifp); >> if (IS_DEFAULT_VNET(curvnet)) >> devctl_notify("IFNET", ifp->if_xname, "ATTACH", NULL); > > -- > Bjoern A. Zeeb r15:7 [-- Attachment #2 --] <html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On May 24, 2024, at 6:12 AM, Bjoern A. Zeeb <<a href="mailto:bzeeb-lists@lists.zabbadoz.net" class="">bzeeb-lists@lists.zabbadoz.net</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta charset="UTF-8" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">On Wed, 22 May 2024, Zhenlei Huang wrote:</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" style="font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""><br class=""><blockquote type="cite" class="">On May 22, 2024, at 12:17 PM, Bjoern A. Zeeb <<a href="mailto:bzeeb-lists@lists.zabbadoz.net" class="">bzeeb-lists@lists.zabbadoz.net</a>> wrote:<br class=""><br class="">Hi,<br class=""><br class="">sorry, I cannot dump; this is a diskless and netdump does not do IPv6;<br class="">needless to say that would be funny in this case anyway; unfortunately<br class="">I have also already re-compiled the kernel so I can only look things up approx.<br class=""><br class="">FreeBSD main from May 13 (f3eeeb959c9b00c89a2e1ff009c78162eb398656).<br class=""><br class="">I assume we lost the ifp from a destroy of a cloned interface in ip6_output()<br class="">between lines 806 and 811?<br class=""><br class=""><br class="">Kernel page fault with the following non-sleepable locks held:<br class="">exclusive rw rawinp (rawinp) r = 0 (0xfffff80002a6e1a0) locked @ /usr/src/sys/netinet6/raw_ip6.c:393<br class="">stack backtrace:<br class="">#0 0xffffffff80bb679c at witness_debugger+0x6c<br class="">#1 0xffffffff80bb7979 at witness_warn+0x3e9<br class="">#2 0xffffffff81061d10 at trap_pfault+0x80<br class="">#3 0xffffffff81033878 at calltrap+0x8<br class="">#4 0xffffffff80d99228 at rip6_send+0x5a8<br class="">#5 0xffffffff80bf570e at sosend_generic+0x5ee<br class="">#6 0xffffffff80bf5c49 at sousrsend+0x79<br class="">#7 0xffffffff80bfbd5c at kern_sendit+0x1bc<br class="">#8 0xffffffff80bfc073 at sendit+0x1b3<br class="">#9 0xffffffff80bfc1ab at sys_sendmsg+0x5b<br class="">#10 0xffffffff81062638 at amd64_syscall+0x158<br class="">#11 0xffffffff8103418b at fast_syscall_common+0xf8<br class="">Created wlan(4) interfaces: wlan<br class=""></blockquote><br class="">Note the creation of wlan, and a following ICMP6 (ping6) packet.<br class=""></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Yes I think it was running netif restart wlan0 in loops.</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">[...]</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" style="font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class="">I'm not quite sure, but it seems the `ifp` is not fully constructed. See<span class="Apple-converted-space"> </span><a href="https://cgit.freebsd.org/src/tree/sys/net/if.c#n950" class="">https://cgit.freebsd.org/src/tree/sys/net/if.c#n950</a><<a href="https://cgit.freebsd.org/src/tree/sys/net/if.c#n950" class="">https://cgit.freebsd.org/src/tree/sys/net/if.c#n950</a>><br class=""><br class="">If I read the code correctly, the clone created interface is made visible via `if_link_ifnet(ifp);` , and at that time the<br class="">`ifp->if_afdata[AF_INET6]` is NULL and is not initialized yet by `if_attachdomain1()` which will call `in6_domifattach()`<br class="">to allocate the required data.<br class=""><br class="">So I guess there is a race condition. I bet this can be repeated easily.<br class=""><br class="">I have not tested this yet, and not sure if it is the right fix, but you can give it a try.<br class=""></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">I'll do; I haven't seen the error happening since on other test</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">machines, so not sure about repeatability.</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">I am also not entirely sure this is not a ping6 ff02::1%wlan0 while</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">the ifp was destroyed by netif restart at the same time the packet was</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">still on the way out?</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""></div></blockquote><div><br class=""></div><div>I think that is possible. There is another report <a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279653" class="">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279653</a> but </div><div>with a different fault path.</div><br class=""><blockquote type="cite" class=""><div class=""><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">If it was during create, the wlan(4) interface would not be associated</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">and UP at that point of if_attach_internal() and</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">`ifconfig inet6 -ifdisabled` would not have been run to be able to send</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">that packet in first place?</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""></div></blockquote><div><br class=""></div><div>Emm, I'm still hacking the lifecycle of ifnet. I think you're right. By default inet6 is disabled on interfaces.</div><div>It seems to be impossible to send packets via disabled interfaces.</div><br class=""><blockquote type="cite" class=""><div class=""><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Othwerwise the packet would have had to "survive" the clone destroy and</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">clone create cycle somewhere ...?</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" style="font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">diff --git a/sys/net/if.c b/sys/net/if.c<br class="">index c3c27fbf678f..16ee5667e7bb 100644<br class="">--- a/sys/net/if.c<br class="">+++ b/sys/net/if.c<br class="">@@ -947,11 +947,11 @@ if_attach_internal(struct ifnet *ifp, bool vmove)<br class=""> }<br class="">#endif<br class=""><br class="">- if_link_ifnet(ifp);<br class="">-<br class=""> if (domain_init_status >= 2)<br class=""> if_attachdomain1(ifp);<br class=""><br class="">+ if_link_ifnet(ifp);<br class="">+<br class=""> EVENTHANDLER_INVOKE(ifnet_arrival_event, ifp);<br class=""> if (IS_DEFAULT_VNET(curvnet))<br class=""> devctl_notify("IFNET", ifp->if_xname, "ATTACH", NULL);<br class=""></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">--<span class="Apple-converted-space"> </span></span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Bjoern A. Zeeb r15:7</span></div></blockquote></div><br class=""><div class=""> <div><br class=""></div> </div> <br class=""></body></html>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F4A7AC7B-30B1-4AF2-B814-0BB7C723042F>