From owner-svn-ports-all@freebsd.org Mon May 11 11:32:11 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EAB1C2DECE1; Mon, 11 May 2020 11:32:11 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49LJgb5kKPz4RK9; Mon, 11 May 2020 11:32:11 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2020.home.selasky.org (unknown [62.141.129.235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 87FEC260276; Mon, 11 May 2020 13:32:03 +0200 (CEST) Subject: Re: svn commit: r534893 - head/multimedia/webcamd To: Jan Beich Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202005110834.04B8YTMU056795@repo.freebsd.org> From: Hans Petter Selasky Message-ID: Date: Mon, 11 May 2020 13:31:10 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 49LJgb5kKPz4RK9 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 May 2020 11:32:12 -0000 On 2020-05-11 13:17, Jan Beich wrote: > Hans Petter Selasky writes: > >> Author: hselasky >> Date: Mon May 11 08:34:28 2020 >> New Revision: 534893 >> URL: https://svnweb.freebsd.org/changeset/ports/534893 >> >> Log: >> Only set COMPAT32 option when building 64-bit platforms. >> >> PR: 245698 >> Approved by: pi (implicit) > [...] >> -.if exists(/usr/lib32/libcuse.so) >> +.include >> + >> +.if ${ARCH} == amd64 || ${ARCH} == aarch64 >> OPTIONS_DEFAULT+= COMPAT32 >> .endif > > Looks pointless. Not only it misses other 64-bit archs like powerpc64 but > also doesn't address bug 245698 where user accidentally enabled COMPAT option. Hi Jan, The COMPAT32 option was enabled by error because the user tried to build both 32-bit and 64-bit world and ports from the same jail. The COMPAT32 option is mostly relevant for platforms that have lots of binary applications in 32-bit mode, like wine-i386-devel, and is not that relevant for power64 nor sparc64, at the moment. It would be better if the ports tree could set a variable by default if we are building for a 64-bit platform! .if ${ARCH64} != "" .endif --HPS > > Try the following instead > > Index: multimedia/webcamd/Makefile > =================================================================== > --- multimedia/webcamd/Makefile (revision 534907) > +++ multimedia/webcamd/Makefile (working copy) > @@ -20,15 +20,13 @@ USE_RC_SUBR= webcamd > SUB_FILES= webcamd.conf > > OPTIONS_DEFINE= COMPAT32 DEBUG HAL VT_CLIENT VT_SERVER DVB INPUT KEYBOARD MOUSE RADIO WEBCAM > -OPTIONS_DEFAULT=DVB HAL INPUT RADIO WEBCAM > +OPTIONS_DEFAULT=COMPAT32 DVB HAL INPUT RADIO WEBCAM > > COMPAT32_DESC= Enable 32-bit compatibility support > COMPAT32_MAKE_ARGS= HAVE_COMPAT32="YES" > > -.include > - > -.if ${ARCH} == amd64 || ${ARCH} == aarch64 > -OPTIONS_DEFAULT+= COMPAT32 > +.if !exists(/usr/lib32/libcuse.so) > +OPTIONS_EXCLUDE+= COMPAT32 > .endif > > HAL_DESC= Build with HAL and DBUS support >