Date: Mon, 28 Oct 2013 10:58:30 +0100 From: Pietro Cerutti <gahr@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, olivier@cochard.me, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r331837 - in head/sysutils/wiimms: . files Message-ID: <20131028095830.GR29559@gahrfit.gahr.ch> In-Reply-To: <20131028094529.GA36401@FreeBSD.org> References: <201310280911.r9S9BbLv080324@svn.freebsd.org> <20131028094529.GA36401@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--bxF9Dep5HzwGj9mC Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2013-Oct-28, 09:45, Alexey Dokuchaev wrote: > On Mon, Oct 28, 2013 at 09:11:37AM +0000, Pietro Cerutti wrote: > > New Revision: 331837 > > URL: http://svnweb.freebsd.org/changeset/ports/331837 > >=20 > > + @${INSTALL_PROGRAM} ${WRKSRC}/wit ${STAGEDIR}${PREFIX}/bin > > + @${INSTALL_PROGRAM} ${WRKSRC}/wwt ${STAGEDIR}${PREFIX}/bin > > + @${INSTALL_PROGRAM} ${WRKSRC}/wdf ${STAGEDIR}${PREFIX}/bin > > + @${LN} -sf wdf ${STAGEDIR}${PREFIX}/bin/wdf-cat > > + @${LN} -sf wdf ${STAGEDIR}${PREFIX}/bin/wdf-dump > > + @${MKDIR} ${STAGEDIR}${DATADIR} > > + @${INSTALL_DATA} ${WRKSRC}/share/* ${STAGEDIR}${DATADIR} > > + @${INSTALL_SCRIPT} ${WRKSRC}/load-titles.sh ${STAGEDIR}${DATADIR} >=20 > Pietro, >=20 > It would be nice to tell maintainer that installation commands should not= be > muted; muting them leaves the users wondering "what did that thing just > install for me?!" and generally pessimizes debugging. If you worry about > extra noise, you can mute mkdir's, but please leave other commands vocal. My fault here, I revised the patch and added support for staging, but failed to notice that INSTALL_ commands were muted. Fixed in r331839. Thanks, --=20 Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp --bxF9Dep5HzwGj9mC Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQJ8BAEBCgBmBQJSbjVBXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQTZERTEwNkE1Qjg1NEI4NUREODZENDlB REQwRDM4RUExOTIwODlFAAoJEK3Q046hkgie0PQP/3yNic7KvOdLEuQPnTziKt+5 McvETyfhnmVpZ1mT5mmM7QMn6202rGT08tO5oflJTleSZ6eT7OtqjJQEGwv6zZ3w aHT0ofrD+ToOguK9POQ+WFCkSijtE+LddbRvEpFw/tVMPLM1PoguvcnVhqre0PGp U/VKzLhOJIs9BTWMOLZhy++ErYcoOQU2Xa4k2gg7XiGy6zxZY6yM1sKhGoGnz9SR acmTfS4Bt7jJxy4lSw0eWfDceya0cTmkgInfz1c3HuH8x0NufHyrKlg2YLoqNLt3 nQfoFQbxgPhYfOifixXftANmDC665h/EiCRIs7p3FSjF0iGTa9ZCSASlncF0bjHh nY5zGaF24vTfdVoTPtFaFeL2prH0OrFEWb4ZPzT+RGAp+EPzJ0Q6r+34/RPpHFKv xH9FG5w7Z6/0wMsjLYFzLUEOuKbddBS/wE9ejiWDUWPNfH/bwPcRKXzMRhUrmtbD mCQWqCmmDqJRRoCrHDxjAovFaBqOdCLCU/qgp5B+AgVqMoczKM47pC1bWY52fBet KnSDMC2XH1/H2SF+QwvIyJWnju6etOkqZqK10JbOmmD+VxSUPGvJQ2+9xqg/QRPw vHg2YQq+C1PdqcuSrrffZ4C/WsJ71eSgz7J4+YmXo1r2nvYPLf4Zz+BQU0nFqFAk 579cPsiIHe5bEC8THDxO =zwM2 -----END PGP SIGNATURE----- --bxF9Dep5HzwGj9mC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131028095830.GR29559>