From owner-svn-src-all@FreeBSD.ORG Wed Feb 12 17:02:35 2014 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CF78C6F4; Wed, 12 Feb 2014 17:02:35 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 53EA6179F; Wed, 12 Feb 2014 17:02:34 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.8/8.14.8) with ESMTP id s1CH2WZD026752 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 12 Feb 2014 21:02:32 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.8/8.14.8/Submit) id s1CH2WlI026751; Wed, 12 Feb 2014 21:02:32 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 12 Feb 2014 21:02:32 +0400 From: Gleb Smirnoff To: Bruce Evans Subject: Re: svn commit: r261796 - head/lib/libkvm Message-ID: <20140212170232.GZ1532@FreeBSD.org> References: <201402120941.s1C9fH5L011741@svn.freebsd.org> <20140213011518.H2280@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140213011518.H2280@besplex.bde.org> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Feb 2014 17:02:35 -0000 Bruce, On Thu, Feb 13, 2014 at 01:52:07AM +1100, Bruce Evans wrote: B> > --- head/lib/libkvm/kvm_getpcpu.3 Wed Feb 12 08:04:38 2014 (r261795) B> > +++ head/lib/libkvm/kvm_getpcpu.3 Wed Feb 12 09:41:17 2014 (r261796) B> > @@ -50,7 +50,7 @@ B> > .Ft void * B> > .Fn kvm_getpcpu "kvm_t *kd" "int cpu" B> > .Ft ssize_t B> > -.Fn kvm_read_zpcpu "kvm_t *kd" "void *buf" "u_long base" "size_t size" "int cpu" B> > +.Fn kvm_read_zpcpu "kvm_t *kd" "u_long base" "void *buf" "size_t size" "int cpu" B> B> This doesn't fix the documentation saying to use the namespace pollution for B> the changed function... B> B> > .Ft uint64_t B> > .Fn kvm_counter_u64_fetch "kvm_t *kd" "u_long base" B> B> ...or for other functions. B> B> This bug was missing in both the header and the man page for all of the B> older functions that use unsigned long (kvm_read(), kvm_uread() and B> kvm_write()). B> B> kvm.h otherwise depends on the full pollution of only for the B> declaration uint64_t. It should declare this itself like it does for all B> the other non-underscored typedefed types that it uses. I'm sorry, Bruce, but my position is the same as before on this. I think that C99 types must be supported by compiler. While they are not, requiring a header that declares C99 types is okay. Typedefing a standard type manually looks for me more ugly than header requirement. -- Totus tuus, Glebius.