From owner-freebsd-current@FreeBSD.ORG  Mon Dec 15 17:05:51 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 643BE16A4CE; Mon, 15 Dec 2003 17:05:51 -0800 (PST)
Received: from white.imgsrc.co.jp (ns.imgsrc.co.jp [210.226.20.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1273143D32; Mon, 15 Dec 2003 17:05:50 -0800 (PST)
	(envelope-from kuriyama@imgsrc.co.jp)
Received: from localhost (localhost [127.0.0.1])
	by white.imgsrc.co.jp (Postfix) with ESMTP
	id 42B13284023; Tue, 16 Dec 2003 10:05:49 +0900 (JST)
Received: from black.imgsrc.co.jp (black.imgsrc.co.jp [2001:218:422:2::130])
	by white.imgsrc.co.jp (Postfix) with ESMTP
	id 3A32528402D; Tue, 16 Dec 2003 10:05:48 +0900 (JST)
Received: from black.imgsrc.co.jp (black.imgsrc.co.jp [2001:218:422:2::130])
	by black.imgsrc.co.jp (Postfix) with ESMTP
	id E9D201E4A63; Tue, 16 Dec 2003 10:05:47 +0900 (JST)
Date: Tue, 16 Dec 2003 10:05:47 +0900
Message-ID: <7my8tdzi50.wl@black.imgsrc.co.jp>
From: Jun Kuriyama <kuriyama@imgsrc.co.jp>
To: Robert Watson <rwatson@FreeBSD.org>
In-Reply-To: <Pine.NEB.3.96L.1031211230113.2793E-100000@fledge.watson.org>
References: <7m7k123dci.wl@black.imgsrc.co.jp>
	<Pine.NEB.3.96L.1031211230113.2793E-100000@fledge.watson.org>
User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen)
	FLIM/1.14.5 (Demachiyanagi) APEL/10.6 Emacs/21.3 (i386--freebsd) MULE/5.0
	(SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen")
Content-Type: text/plain; charset=US-ASCII
X-Virus-Scanned: by AMaViS snapshot-20020531
cc: Current <freebsd-current@FreeBSD.org>
cc: jhb@FreeBSD.org
Subject: Re: vn_fullpath: 0xc85e24a0 is not locked but should be
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Dec 2003 01:05:51 -0000

At Thu, 11 Dec 2003 23:14:50 -0500 (EST),
Robert Watson wrote:
> Index: procfs.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/fs/procfs/procfs.c,v
> retrieving revision 1.9
> diff -u -r1.9 procfs.c
> --- procfs.c	17 Apr 2003 22:12:12 -0000	1.9
> +++ procfs.c	12 Dec 2003 04:13:10 -0000
> @@ -70,7 +70,9 @@
>  	char *fullpath = "unknown";
>  	char *freepath = NULL;
>  
> +	vn_lock(p->p_textvp, LK_EXCLUSIVE | LK_RETRY, td);
>  	vn_fullpath(td, p->p_textvp, &fullpath, &freepath);
> +	VOP_UNLOCK(p->p_textvp, 0, td);
>  	sbuf_printf(sb, "%s", fullpath);
>  	if (freepath)
>  		free(freepath, M_TEMP);

I'm running my box with this patch (and DEBUG_VFS_LOCKS) and it seems
fine.


-- 
Jun Kuriyama <kuriyama@imgsrc.co.jp> // IMG SRC, Inc.
             <kuriyama@FreeBSD.org> // FreeBSD Project