Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 17 May 2010 16:28:56 GMT
From:      Andras Horvath <han@log69.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/146667: graphics/aaphoto ports Makefile fix to compile on FreeBSD 6.x and earlier
Message-ID:  <201005171628.o4HGSuiI070121@www.freebsd.org>
Resent-Message-ID: <201005171630.o4HGU5bI096604@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         146667
>Category:       ports
>Synopsis:       graphics/aaphoto ports Makefile fix to compile on FreeBSD 6.x and earlier
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 17 16:30:04 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Andras Horvath
>Release:        8.0-RELEASE-p2
>Organization:
>Environment:
>Description:
The port needs OpenMP multi processing feature since version 0.37 by default. GCC supports this since version 4.2.

The default CFLAGS are set to compile with OpenMP, but GCC does not have support for it on FreeBSD 6.x and earlier platforms.

I added CFLAGS to deactivate OpenMP directives and linker switches on earlier versions than 7.x.

I also added documentation files to install. It was missing before, and the source contains it anyway.

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ru graphics/aaphoto.old/Makefile graphics/aaphoto/Makefile
--- graphics/aaphoto.old/Makefile	2010-05-17 17:58:57.000000000 +0200
+++ graphics/aaphoto/Makefile	2010-05-17 17:56:38.000000000 +0200
@@ -7,6 +7,7 @@
 
 PORTNAME=	aaphoto
 PORTVERSION=	0.37
+PORTREVISION=	1
 CATEGORIES=	graphics
 MASTER_SITES=	http://log69.com/downloads/
 DISTNAME=	${PORTNAME}_sources_v${PORTVERSION}
@@ -25,10 +26,26 @@
 WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
 
 PLIST_FILES=	bin/aaphoto
+PORTDOCS=	AUTHORS ChangeLog COPYING COPYRIGHT INSTALL LICENSE \
+		NEWS README TODO
+
+.include <bsd.port.pre.mk>
+
+.if ${OSVERSION} < 700000
+CFLAGS+=	-fno-openmp -Wno-unknown-pragmas -U__OPENMP__
+.endif
 
 do-install:
 .for FILE in aaphoto
 	${INSTALL_PROGRAM} ${WRKSRC}/${FILE} ${PREFIX}/bin
 .endfor
 
-.include <bsd.port.mk>
+post-install:
+.if !defined(NOPORTDOCS)
+	${MKDIR} ${DOCSDIR}
+.for i in ${PORTDOCS}
+	${INSTALL_DATA} ${WRKSRC}/${i} ${DOCSDIR}
+.endfor
+.endif
+
+.include <bsd.port.post.mk>


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201005171628.o4HGSuiI070121>