From owner-freebsd-bugs@FreeBSD.ORG  Thu Jul 14 23:50:22 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 563AF16A41C
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 14 Jul 2005 23:50:22 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 24D5643D45
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 14 Jul 2005 23:50:22 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j6ENoMC0089475
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 14 Jul 2005 23:50:22 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j6ENoLjY089474;
	Thu, 14 Jul 2005 23:50:21 GMT (envelope-from gnats)
Date: Thu, 14 Jul 2005 23:50:21 GMT
Message-Id: <200507142350.j6ENoLjY089474@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Sean Winn <sean@gothic.net.au>
Cc: 
Subject: Re: bin/83468: imported OpenBSD dhclient handles hostnames
	differently to ISC DHCP 3 - come through as hex
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Sean Winn <sean@gothic.net.au>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jul 2005 23:50:22 -0000

The following reply was made to PR bin/83468; it has been noted by GNATS.

From: Sean Winn <sean@gothic.net.au>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/83468: imported OpenBSD dhclient handles hostnames differently to ISC DHCP 3 - come through as hex
Date: Fri, 15 Jul 2005 09:49:02 +1000

 What's missing is the patch (also on 
 http://www.gothic.net.au/~sean/dhclient-options.c.patch ) ...
 
 Index: sbin/dhclient/options.c
 ===================================================================
 RCS file: /home/ncvs/src/sbin/dhclient/options.c,v
 retrieving revision 1.1.1.1
 diff -u -u -r1.1.1.1 options.c
 --- sbin/dhclient/options.c     7 Jun 2005 04:05:08 -0000       1.1.1.1
 +++ sbin/dhclient/options.c     14 Jul 2005 16:09:27 -0000
 @@ -486,7 +486,11 @@
                                  if (!isascii(data[k]) ||
                                      !isprint(data[k]))
                                          break;
 -                       if (k == len) {
 +            /* If we found no bogus characters, or the bogus
 +               character we found is a trailing NUL, it's
 +                  okay to print this option as text. */
 +
 +                       if (k == len || (k + 1 == len && data [k] == 
 0)) {
                                  fmtbuf[i] = 't';
                                  numhunk = -2;
                          } else {