From owner-svn-src-all@FreeBSD.ORG Tue Nov 18 14:24:56 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 40E83C30; Tue, 18 Nov 2014 14:24:56 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9A3FCCF7; Tue, 18 Nov 2014 14:24:55 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id sAIEOn30038290 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 18 Nov 2014 16:24:49 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua sAIEOn30038290 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id sAIEOnRt038289; Tue, 18 Nov 2014 16:24:49 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 18 Nov 2014 16:24:49 +0200 From: Konstantin Belousov To: Mark Felder Subject: Re: svn commit: r274653 - head/usr.sbin/freebsd-update Message-ID: <20141118142449.GW17068@kib.kiev.ua> References: <201411181338.sAIDc9U3051869@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201411181338.sAIDc9U3051869@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Nov 2014 14:24:56 -0000 On Tue, Nov 18, 2014 at 01:38:09PM +0000, Mark Felder wrote: > Author: feld (ports committer) > Date: Tue Nov 18 13:38:09 2014 > New Revision: 274653 > URL: https://svnweb.freebsd.org/changeset/base/274653 > > Log: > Re-work non-persistent filesystem detection as it was not possible to > detect /dev/md backed mfs filesystems that way. > > Differential Revision: https://reviews.freebsd.org/D1163 > Approved by: ian > > Modified: > head/usr.sbin/freebsd-update/freebsd-update.sh > > Modified: head/usr.sbin/freebsd-update/freebsd-update.sh > ============================================================================== > --- head/usr.sbin/freebsd-update/freebsd-update.sh Tue Nov 18 13:38:07 2014 (r274652) > +++ head/usr.sbin/freebsd-update/freebsd-update.sh Tue Nov 18 13:38:09 2014 (r274653) > @@ -604,14 +604,13 @@ fetchupgrade_check_params () { > echo ${WORKDIR} > exit 1 > fi > - for i in tmpfs mdmfs; do > - if df -t ${i} ${WORKDIR} >/dev/null 2>1; then > - echo -n "`basename $0`: " > - echo -n "${_WORKDIR_bad2}" > - echo ${WORKDIR} > - exit 1 > - fi > - done > + case `df -T ${WORKDIR}` in */dev/md[0-9]* | *tmpfs*) > + echo -n "`basename $0`: " > + echo -n "${_WORKDIR_bad2}" > + echo ${WORKDIR} > + exit 1 > + ;; > + esac > chmod 700 ${WORKDIR} > cd ${WORKDIR} || exit 1 > Why do you suppose that md-backed volumes are not persistent ? vnode-backed devices are stable.