Date: Wed, 03 Mar 2021 08:05:56 -0600 From: "Brandon Bergren" <bdragon@FreeBSD.org> To: rgrimes@FreeBSD.org Cc: "Ed Maste" <emaste@FreeBSD.org>, "Warner Losh" <imp@bsdimp.com>, "Nathan Whitehorn" <nwhitehorn@FreeBSD.org>, src-committers <src-committers@FreeBSD.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@FreeBSD.org>, dev-commits-src-main@FreeBSD.org Subject: =?UTF-8?Q?Re:_git:_2c26d77d989a_-_main_-_Remove_/boot/efi_from_mtree, _mi?= =?UTF-8?Q?ssed_in_0b7472b3d8d2.?= Message-ID: <14d09680-1036-4a7e-8a0e-c3063cac8bc9@www.fastmail.com> In-Reply-To: <202103031253.123CrxKG051357@gndrsh.dnsmgr.net> References: <202103031253.123CrxKG051357@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 3, 2021, at 6:53 AM, Rodney W. Grimes wrote:
> What am I missing here? One place I am being told this is run in
> an environment that may not even be an EFI booted system, and in
> another place it is being used as a test if something is mounted
> on it, which should only be true on an EFI booted system.
That the script in question is a generic script that runs as part of bsdinstall on every platform and has to be universal.
The actual *problem* here is that usr.sbin/bsdinstall/scripts/bootconfig has a default case that is
*) die "Unsupported arch $(uname -m) for UEFI install"
which then causes the main script to bail out, leaving the system in a half-installed state.
If that had just been an exit 0 this would have never been a problem, I suppose.
Before the original change that broke this, there was a check that the script was not running on powerpc or mips platforms before running the efi bits, but this got taken out.
--
Brandon Bergren
bdragon@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?14d09680-1036-4a7e-8a0e-c3063cac8bc9>