Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 16 Dec 1996 21:16:39 +0300 (MSK)
From:      =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7=2C_Andrey_Chernov?= <ache@nagual.ru>
To:        Joerg Wunsch <joerg@freefall.freebsd.org>
Cc:        CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org
Subject:   Re: cvs commit:  src/lib/libc/locale collate.c setrunelocale.c
Message-ID:  <Pine.BSF.3.95.961216211511.887A-100000@nagual.ru>
In-Reply-To: <199612161733.JAA19458@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 16 Dec 1996, Joerg Wunsch wrote:

> joerg       96/12/16 09:33:00
> 
>   Modified:    lib/libc/locale  collate.c setrunelocale.c
>   Log:
>   Fix yet another buffer overflow. :-(
>   
>   Vulnerable: all programs that use setlocale(LC_COLLATE),
>   setlocale(LC_CTYPE), or setlocale(LC_ALL).  The only setuid/setgid
>   binary i've found for this is w(1).
>   

Please, back it out, you fix _nothing_, just add snprintf bloat!
Buffer range checking already done at earlier stage.

-- 
Andrey A. Chernov
<ache@nagual.ru>
http://www.nagual.ru/~ache/




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.95.961216211511.887A-100000>