From nobody Tue Feb 17 20:01:46 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fFrBw1VnGz6Ryyl; Tue, 17 Feb 2026 20:02:00 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4fFrBv3BXZz3hLl; Tue, 17 Feb 2026 20:01:59 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 61HK1kZf021860; Tue, 17 Feb 2026 22:01:49 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 61HK1kZf021860 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 61HK1kEW021859; Tue, 17 Feb 2026 22:01:46 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 17 Feb 2026 22:01:46 +0200 From: Konstantin Belousov To: John Baldwin Cc: "Enji Cooper (yaneurabeya)" , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 97ce8f7d2b8e - main - amd64: define and use STACKALIGN and REDZONE_SZ Message-ID: References: <698a1ffe.26e3c.47182d66@gitrepo.freebsd.org> <1d35e758-ff0d-4fb3-9a4c-a0fc69182d41@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1d35e758-ff0d-4fb3-9a4c-a0fc69182d41@FreeBSD.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.2 X-Spam-Checker-Version: SpamAssassin 4.0.2 (2025-08-27) on tom.home X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Queue-Id: 4fFrBv3BXZz3hLl X-Spamd-Bar: ---- On Tue, Feb 17, 2026 at 02:42:20PM -0500, John Baldwin wrote: > On 2/16/26 21:44, Konstantin Belousov wrote: > > On Mon, Feb 16, 2026 at 05:01:58PM -0800, Enji Cooper (yaneurabeya) wrote: > > > > > > > On Feb 9, 2026, at 9:57 AM, Konstantin Belousov wrote: > > > > > > > > The branch main has been updated by kib: > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=97ce8f7d2b8eff42460f60e8c49d9849b58b6e81 > > > > > > > > commit 97ce8f7d2b8eff42460f60e8c49d9849b58b6e81 > > > > Author: Konstantin Belousov > > > > AuthorDate: 2026-02-07 00:36:44 +0000 > > > > Commit: Konstantin Belousov > > > > CommitDate: 2026-02-09 17:57:00 +0000 > > > > > > > > amd64: define and use STACKALIGN and REDZONE_SZ > > > > > > > > Reviewed by: brooks, emaste, jhb > > > > Sponsored by: The FreeBSD Foundation > > > > MFC after: 1 week > > > > Differential revision: https://reviews.freebsd.org/D55151 > > > > > > Hi kib@! > > > It looks like this broke the build with gcc12 on main: https://ci.freebsd.org/job/FreeBSD-main-amd64-gcc14_build/2893/console . > > > > https://reviews.freebsd.org/D55319 > > might be the fix. > > I have the same thing at https://reviews.freebsd.org/D55161 > > Per my comments there, I do think it might break 32-bit kernels, but we probably > don't care about that. (Namely, if rounddown2() is used on a type larger than > uintptr_t such as trunc_page on a vm_paddr_t on i386, this change truncates the > value). > > If we really care, we could use _Generic or the like to only use the uintptr_t > casts for pointer types. I must admit that I initially wrote the cast to uintmax_t, and only then looked at the nearby code (__builtin_align_up() and others). Since uintptr_t was good enough for them, I used it in the patch as well.