From owner-freebsd-current@FreeBSD.ORG Fri Dec 16 09:47:47 2011 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1D5EA1065783; Fri, 16 Dec 2011 09:47:47 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 3411E8FC1A; Fri, 16 Dec 2011 09:47:45 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id LAA15209; Fri, 16 Dec 2011 11:47:43 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1RbUOE-0005RF-Hg; Fri, 16 Dec 2011 11:47:42 +0200 Message-ID: <4EEB13BD.3060401@FreeBSD.org> Date: Fri, 16 Dec 2011 11:47:41 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:8.0) Gecko/20111206 Thunderbird/8.0 MIME-Version: 1.0 To: arch@FreeBSD.org, FreeBSD current References: <4EE52469.3050201@FreeBSD.org> <4EE79014.3070006@FreeBSD.org> In-Reply-To: <4EE79014.3070006@FreeBSD.org> X-Enigmail-Version: undefined Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Subject: Re: grabbing console (syscons) in kernel X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Dec 2011 09:47:47 -0000 on 13/12/2011 19:49 Andriy Gapon said the following: > on 11/12/2011 23:45 Andriy Gapon said the following: >> >> There are a few cases when the kernel needs to interact with a user via syscons. >> This is the cases where the kernel not only spews some output but also expects >> some input. Some examples are: >> - asking for a root filesystem specification >> - entering ddb >> - asking to press a key for reboot >> >> In this cases the kernel implicitly grabs the console for its own use. >> I'd like to make action more explicit. >> >> What do you think about the approach and implementation in the following patches? >> Thank you! >> >> https://gitorious.org/~avg/freebsd/avgbsd/commit/5248b49ebf84d98a0597fa5aa4d813a38f581acc >> https://gitorious.org/~avg/freebsd/avgbsd/commit/a0849c52242378474bb2eaa41726376fbc4c5bf6 >> https://gitorious.org/~avg/freebsd/avgbsd/commit/a67515cbd720b16f03ba435ed182966a8a338b15 >> https://gitorious.org/~avg/freebsd/avgbsd/commit/b8864b68b4c0e26ece065a38301c305833be32eb >> https://gitorious.org/~avg/freebsd/avgbsd/commit/1017ae425d8abecd7482bd6c6deaaf9f25f5c6cd > > > I was advised that the above links might not be the best way to present the > patches for review, so here are them as a single diff file: > http://people.freebsd.org/~avg/cngrab.diff I plan to start committing these changes tomorrow. So if this is "your area" or you want to be sure that nothing gets broken in this area, then please review the changes or let me know your review plans. Post-commit reviews are of course welcome as usual, but pre-commit reviews are preferred. Thank you. >> P.S. one of the benefits is that a keyboard is put into and out of the polling >> mode before getting all the required input and after that; not around each >> character as it is done now in rather twisted way. -- Andriy Gapon