From owner-freebsd-bugs@FreeBSD.ORG Tue May 9 10:00:40 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 90C0316A405 for ; Tue, 9 May 2006 10:00:40 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 122EC43D48 for ; Tue, 9 May 2006 10:00:40 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k49A0dlm099087 for ; Tue, 9 May 2006 10:00:39 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k49A0dvJ099086; Tue, 9 May 2006 10:00:39 GMT (envelope-from gnats) Resent-Date: Tue, 9 May 2006 10:00:39 GMT Resent-Message-Id: <200605091000.k49A0dvJ099086@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Cheng-Lung Sung Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BAC8D16A403 for ; Tue, 9 May 2006 09:59:02 +0000 (UTC) (envelope-from clsung@going04.iis.sinica.edu.tw) Received: from going04.iis.sinica.edu.tw (going04.iis.sinica.edu.tw [140.109.19.154]) by mx1.FreeBSD.org (Postfix) with ESMTP id 67F8D43D49 for ; Tue, 9 May 2006 09:59:02 +0000 (GMT) (envelope-from clsung@going04.iis.sinica.edu.tw) Received: by going04.iis.sinica.edu.tw (Postfix, from userid 1002) id 12AEE28471; Tue, 9 May 2006 17:59:08 +0800 (CST) Message-Id: <20060509095908.12AEE28471@going04.iis.sinica.edu.tw> Date: Tue, 9 May 2006 17:59:08 +0800 (CST) From: Cheng-Lung Sung To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: conf/97024: [patch] rc.d/jail start ignore failed jail but still put jid under /var/run X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Cheng-Lung Sung List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 May 2006 10:00:40 -0000 >Number: 97024 >Category: conf >Synopsis: [patch] rc.d/jail start ignore failed jail but still put jid under /var/run >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Tue May 09 10:00:39 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Cheng-Lung Sung >Release: FreeBSD 6.1-STABLE i386 >Organization: FreeBSD @ Taiwan >Environment: System: FreeBSD going04.iis.sinica.edu.tw 6.1-STABLE FreeBSD 6.1-STABLE #9: Mon May 8 09:53:48 CST 2006 root@going04.iis.sinica.edu.tw:/usr/obj/usr/src/sys/GOING04 i386 >Description: 'rc.d/jail start' echoes successful jail's name, however it still put failing jail's id to /var/run/. It should be able to tell user what's going on instead of just ignoring it. >How-To-Repeat: establish two jail, choose one and remove /bin, then try to start two jail via rc.d/jail start, you should only one jail's name was echoed, but rc.d/jail stop can stop these two jail. >Fix: --- rc.d/jail.orig Tue May 9 17:20:29 2006 +++ rc.d/jail Tue May 9 17:42:02 2006 @@ -210,11 +210,16 @@ _tmp_jail=${_tmp_dir}/jail.$$ eval jail ${jail_flags} -i ${jail_rootdir} ${jail_hostname} \ ${jail_ip} ${jail_exec_start} > ${_tmp_jail} 2>&1 - [ "$?" -eq 0 ] && echo -n " $jail_hostname" - _jail_id=$(head -1 ${_tmp_jail}) - tail +2 ${_tmp_jail} >${jail_rootdir}/var/log/console.log + if [ "$?" -eq 0 ] ; then + echo -n " $jail_hostname" + _jail_id=$(head -1 ${_tmp_jail}) + tail +2 ${_tmp_jail} >${jail_rootdir}/var/log/console.log + echo ${_jail_id} > /var/run/jail_${_jail}.id + else + echo " cannot start jail ${_jail}. message: " + tail +2 ${_tmp_jail} + fi rm -f ${_tmp_jail} - echo ${_jail_id} > /var/run/jail_${_jail}.id done rmdir ${_tmp_dir} echo '.' @@ -244,7 +249,7 @@ fi rm /var/run/jail_${_jail}.id else - echo "cannot stop jail ${_jail}. No jail id in /var/run" + echo " cannot stop jail ${_jail}. No jail id in /var/run" fi done echo '.' >Release-Note: >Audit-Trail: >Unformatted: