From owner-freebsd-net@freebsd.org  Sun Apr 24 11:33:21 2016
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1DE72B1B5C3
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Sun, 24 Apr 2016 11:33:21 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org
 [IPv6:2610:1c1:1:607c::16:b])
 by mx1.freebsd.org (Postfix) with ESMTP id E60F71A13
 for <freebsd-net@freebsd.org>; Sun, 24 Apr 2016 11:33:20 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346)
 id 63CE2C44C; Sun, 24 Apr 2016 11:33:20 +0000 (UTC)
Date: Sun, 24 Apr 2016 11:33:20 +0000
To: freebsd-net@freebsd.org
From: "kristof (Kristof Provost)" <phabric-noreply@FreeBSD.org>
Reply-to: D1944+325+8925873bdc96dfc2@reviews.freebsd.org
Subject: [Differential] D1944: PF and VIMAGE fixes
Message-ID: <f5b723ec562030ea1421af96623f564b@localhost.localdomain>
X-Priority: 3
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
Thread-Topic: D1944: PF and VIMAGE fixes
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-cc3fb6vejhnh7xhqtpkr>
X-Phabricator-To: <PHID-USER-ug3kdqciycpghwfscl6v>
X-Phabricator-To: <PHID-USER-d4twv4w2hsoq7prc6boa>
X-Phabricator-To: <PHID-USER-ejqqvwsrqxen3vd3xete>
X-Phabricator-To: <PHID-USER-sfbxp2cksgub2ywlvupr>
X-Phabricator-To: <PHID-USER-wsgmn2xibp2yi52xz6fn>
X-Phabricator-To: <PHID-USER-2q5asccazp7ohcpzdm6o>
X-Phabricator-To: <PHID-USER-ogl2udicsobdviqdulu3>
X-Phabricator-To: <PHID-USER-fap6rlbm354nurn2trrm>
X-Phabricator-Cc: <PHID-USER-ynkpst6zmidlgy3dvqdn>
X-Phabricator-Cc: <PHID-USER-mn3yvl63s5htra6shaq6>
X-Phabricator-Cc: <PHID-USER-4o7cgpdmpw4gs3l6mool>
X-Phabricator-Cc: <PHID-USER-odydowamvpays7n7qddl>
X-Phabricator-Cc: <PHID-USER-mhzsgq7klbzjcspjzvus>
X-Phabricator-Cc: <PHID-USER-hvftay72cq6umfijkhnv>
X-Phabricator-Cc: <PHID-USER-6ps3unnxvniqcn5kdjn5>
X-Phabricator-Cc: <PHID-USER-nq3ekgbv4mp4q2raw2n7>
X-Phabricator-Cc: <PHID-USER-dyyyzfp34mimhzvg33tk>
Precedence: bulk
In-Reply-To: <differential-rev-PHID-DREV-clct73g5zt63yh3lvwzr-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-clct73g5zt63yh3lvwzr-req@FreeBSD.org>
Thread-Index: NDc2NzM0MzY4OTdiYThiNTU1MjY2ZDZmMTJiIFccrwA=
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.21
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Apr 2016 11:33:21 -0000

kristof added inline comments.

INLINE COMMENTS
  sys/netpfil/pf/pf_if.c:130 I don't understand why this is required. Surely if an ifnet lives in V_ifnet (so, lives in the current vnet) ifp->if_vnet is always going to be curvnet?
  sys/netpfil/pf/pf_if.c:141 Why add curvnet here?
  pfi_attach_ifnet_event doesn't use its argument.
  sys/netpfil/pf/pf_if.c:143 Same as above.
  sys/netpfil/pf/pf_if.c:151 Same as above.
  sys/netpfil/pf/pf_if.c:814 I believe this is correct, but should probably include adding an __unused annotation to arg, and removing the 'curvnet' argument from the EVENTHANDLER_REGISTER() call.

REVISION DETAIL
  https://reviews.freebsd.org/D1944

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri
Cc: ryan_timewasted.me, mmoll, javier_ovi_yahoo.com, farrokhi, julian, robak, freebsd-virtualization-list, freebsd-pf-list, freebsd-net-list