From owner-freebsd-hackers@FreeBSD.ORG  Tue Sep 19 08:12:25 2006
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
X-Original-To: freebsd-hackers@freebsd.org
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0AEB216A403;
	Tue, 19 Sep 2006 08:12:25 +0000 (UTC)
	(envelope-from umka@sevcity.net)
Received: from mail.sevcity.net (ns.sevcity.net [193.47.166.213])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D38C143D5D;
	Tue, 19 Sep 2006 08:12:22 +0000 (GMT)
	(envelope-from umka@sevcity.net)
Received: from mail.sevcity.net (service.sevcity [127.0.0.1])
	by mail.sevcity.net (Postfix) with ESMTP id 84DD617000A;
	Tue, 19 Sep 2006 11:12:49 +0300 (EEST)
Received: from berloga.shadowland (umka.sevcity.net [193.47.166.138])
	by mail.sevcity.net (Postfix) with ESMTP id C079F170004;
	Tue, 19 Sep 2006 11:12:46 +0300 (EEST)
Received: from berloga.shadowland (berloga.shadowland [127.0.0.1])
	by berloga.shadowland (8.12.11.20060308/8.12.11) with ESMTP id
	k8J8CHeL004146; Tue, 19 Sep 2006 11:12:17 +0300
Received: (from root@localhost)
	by berloga.shadowland (8.12.11.20060308/8.12.11/Submit) id
	k8J8CG6e004143; Tue, 19 Sep 2006 11:12:16 +0300
From: Alex Lyashkov <umka@sevcity.net>
To: John Baldwin <jhb@freebsd.org>
In-Reply-To: <200609181750.58145.jhb@freebsd.org>
References: <1158407656.3215.33.camel@berloga.shadowland>
	<20060917211905.GA64182@xor.obsecurity.org>
	<1158530904.3213.1.camel@berloga.shadowland>
	<200609181750.58145.jhb@freebsd.org>
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: quoted-printable
Organization: SevcityNet
Message-Id: <1158653536.3213.5.camel@berloga.shadowland>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-17) 
Date: Tue, 19 Sep 2006 11:12:16 +0300
X-Virus-Scanned: ClamAV using ClamSMTP
Cc: freebsd-hackers@freebsd.org, Kris Kennaway <kris@obsecurity.org>
Subject: Re: jail2 patchset 12
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Sep 2006 08:12:25 -0000

thanks for point this :( i will rewrite old jail api as wrapper to new
API for avoid similar errors...

=F7 =F7=D4=D2, 19.09.2006, =D7 00:50, John Baldwin =D0=C9=DB=C5=D4:
> On Sunday 17 September 2006 18:08, Alex Lyashkov wrote:
> > Thanks for you report. I really more test new jail2 API then old :(
> > Please apply this patch.
> >=20
> > # p4 diff -du kern_jail.c
> > =3D=3D=3D=3D //depot/projects/jail2/sys/kern/kern_jail.c#4 -
> > /root/jail2/sys/kern/kern_jail.c =3D=3D=3D=3D
> > @@ -316,6 +316,7 @@
> >         if (error)
> >                 return (error);
> >=20
> > +       mtx_lock(&allprison_mtx);
> >         pr =3D prison_find(uap->jid);
> >         if (pr =3D=3D NULL) {
> >                 return (ESRCH);
>=20
> Does this leak the lock in the ESRCH case now?
> =20