From owner-svn-src-all@freebsd.org Mon Mar 21 20:56:18 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DCA49AD89A2; Mon, 21 Mar 2016 20:56:18 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ig0-x231.google.com (mail-ig0-x231.google.com [IPv6:2607:f8b0:4001:c05::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A5F611B3E; Mon, 21 Mar 2016 20:56:18 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-ig0-x231.google.com with SMTP id nk17so80769513igb.1; Mon, 21 Mar 2016 13:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-transfer-encoding; bh=WCSTT6W8VUtl6s+PW1WWb20P70/pf6bSkaGGNJLld9A=; b=goxMZcbcj+ofl4Gj9ybbhG3zsLZbHxBWduJngGzqKcc3rvBpkt8DLhyo4/i2Y3hRzF 8li1I7fRZYFg5BHK/W5agu8iJxLiipQSlibBdzY7uTyrEgzDNG9vXNW9IfOomnYrbT6r QIZj6XwONA6OGJN7PGHEr9T7q5A1QDgftQ8X8uFTQbrlaI116HM+ohQ0vY1S6CzSspRk jTbDNYFRfE3r9iiDmcvm7N+24btqa/BsYXMmVW7Zzgc7ryvPVEeUM9eyT5VK4+mQm1iG WYkEiRMUo8IHCyNiMbSXNGIYGvsiYUp9M+HiIzmKzhZ5OSVG+AVNSkPOXSqNdnXI5ZVi JeIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=WCSTT6W8VUtl6s+PW1WWb20P70/pf6bSkaGGNJLld9A=; b=MppKNC0PZNCfNu4fcUUlptuEawEDhd1iNoAeFup5h4TS1ellxjdZRvnMHJa6KcLTJw sKonsfccclzklNQvsEig3BWKVNuFqjPUhJ2jB4CLyaCRWtU4Q8RAAinMLNg/8sjFTtru 70IQckTAlBBXCQvgW0vKv9RQZrP2WSNCnUqhMn4b/VzaFtDC40PlGtJmTX5VdpUM2mh2 nsjelS5ZA2iVcM91FLvPkT+LzYyrt+whYMGbxnuCd04JLQyEXhf0fF+UKRyXJ/+iq92V j3l/BSywa5zCSgtNtt8k3wImrs0JBHABl2mfaPy9Dmzwqw3oRWX6rUIwPLfQBfSBgfHV lLng== X-Gm-Message-State: AD7BkJI0cMWTLF6w7noOMLsguwkRJmxDIxQ0iEsYK1QDPRNLMQh3eK7nANmefw3vD4FcPLjbeaoQxVtRUfOo4g== MIME-Version: 1.0 X-Received: by 10.50.78.200 with SMTP id d8mr14015545igx.61.1458593778011; Mon, 21 Mar 2016 13:56:18 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.36.14.19 with HTTP; Mon, 21 Mar 2016 13:56:17 -0700 (PDT) In-Reply-To: <4D26F4EE-A51F-44E1-B66C-4498FA029C6F@bsdimp.com> References: <201603210551.u2L5pL1X037311@repo.freebsd.org> <20160321203528.GC1254@FreeBSD.org> <4D26F4EE-A51F-44E1-B66C-4498FA029C6F@bsdimp.com> Date: Mon, 21 Mar 2016 13:56:17 -0700 X-Google-Sender-Auth: e-frHU8b-gEv6rDGZWM-zzGG_0g Message-ID: Subject: Re: svn commit: r297136 - head/sys/conf From: Adrian Chadd To: Warner Losh Cc: Gleb Smirnoff , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2016 20:56:19 -0000 On 21 March 2016 at 13:52, Warner Losh wrote: > >> On Mar 21, 2016, at 2:35 PM, Gleb Smirnoff wrote: >> >> On Mon, Mar 21, 2016 at 05:51:21AM +0000, Adrian Chadd wrote: >> A> Author: adrian >> A> Date: Mon Mar 21 05:51:21 2016 >> A> New Revision: 297136 >> A> URL: https://svnweb.freebsd.org/changeset/base/297136 >> A> >> A> Log: >> A> Remove from NOTES - it's built as a module now. >> >> You are doing wrong. A driver must be buildable as a module and >> statically as well. >> >> It is legitimate to remove from GENERIC, but not from NOTES. > > In private conversations with Adrian, he indicated that he=E2=80=99s abou= t to > reorganize this driver substantially. He=E2=80=99ll make sure it works du= ring the > record period as a module, but can=E2=80=99t guarantee he won=E2=80=99t b= reak building > it into the kernel. So he took it out from here so that the LINT build > doesn=E2=80=99t break. He intends to reconnect it once he=E2=80=99s done = with the > rearrangement. +1 here. rtwn and urtwn are effectively the same family but with a different DMA front-end, so I'd like to take a stab at unifying all of that. Otherwise adding 11ac drivers in that family will just be annoyingly duplicate-y. -adrian