From owner-freebsd-testing@FreeBSD.ORG Fri Jul 18 21:52:11 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 93E0C198; Fri, 18 Jul 2014 21:52:11 +0000 (UTC) Received: from mail-pa0-x232.google.com (mail-pa0-x232.google.com [IPv6:2607:f8b0:400e:c03::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 610A62344; Fri, 18 Jul 2014 21:52:11 +0000 (UTC) Received: by mail-pa0-f50.google.com with SMTP id et14so6229498pad.9 for ; Fri, 18 Jul 2014 14:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-type:mime-version:subject:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=aA/p0ESh8lCy27OoITdc/hUBDknJkILgLlbVv+w3cN8=; b=KYa3o9HTGiHnhrxYPTxy8Kugagn1UhFPkwpmnHX2aojWR0WkmUUdFDua823JHvNL2f 4TcZWk0bUkLhm72dksE7LlTSCNbSOUh3Ga8xy3NYj7KP/8XKYTS4Z1ohlVdz/QU6pHX6 /bon+hbr7oRLjCkz0K0lFlFNZY/KHGCY3fnPuuHGP0c90oP+svcr92+GgIsOnukPdCvm L0Q3tCD/j188dUg+taZBXLB2mZczim4Dk0Hqf1oZ0IXUTLcswyuFfe47u+XBQTdS1HzL sWScckqnwdpUrK94KVkzCrdnob+0hf2rTPfbkLTbjLEdUD/XesNqIsTMoMjcEtpgLfR6 GJbg== X-Received: by 10.68.203.132 with SMTP id kq4mr8681168pbc.12.1405720330943; Fri, 18 Jul 2014 14:52:10 -0700 (PDT) Received: from ?IPv6:2601:8:ab80:7d6:803c:321d:601c:70ce? ([2601:8:ab80:7d6:803c:321d:601c:70ce]) by mx.google.com with ESMTPSA id xz7sm27274091pac.3.2014.07.18.14.52.09 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 18 Jul 2014 14:52:10 -0700 (PDT) From: Garrett Cooper X-Google-Original-From: Garrett Cooper Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: Need input on preference on location of 3rd party tests vs FreeBSD tests In-Reply-To: Date: Fri, 18 Jul 2014 14:52:09 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <4D9EB4FA-672A-47AC-8F6E-19D2B3FAB3F5@gmail.com> References: To: Alan Somers X-Mailer: Apple Mail (2.1878.6) Cc: "freebsd-testing@freebsd.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jul 2014 21:52:11 -0000 On Jul 18, 2014, at 7:45 AM, Alan Somers wrote: > On Fri, Jul 18, 2014 at 1:11 AM, Garrett Cooper = wrote: >> Hi all, >> One of the things that I've done on my fork of FreeBSD is I've = imported ATF test suites from NetBSD and I have integrated existing test = suites from freebsd's tools/regression tree into Kyua as well. Due to = the size and difference in test content/coverage, I pulled lib/libc and = lib/msun from bother sources and integrated them into Kyua. What I did = was I put the netbsd testcases into the tests/ subdirectory and put the = FreeBSD test suites into a tests/legacy subdirectory. The goal was that = the legacy directory would eventually be converted over to atf testcases = and then could be removed once the conversion was complete. >> I'm not sure if this scheme makes sense though. Does anyone have a = preference as to whether or not this makes sense? >> Thanks! >> -Garrett >=20 >=20 > I don't understand. What did you put in tests/legacy? The tests from tools/regression. tests/ contains the tests from NetBSD. > If you're just > copying from tools/regression, why not simply leave them in place > until you convert them to ATF? I moved the files over into their respective locations to avoid having = to change build machinery at the top level, but you bring up a valid = concern. These pieces are the exception, not the norm, so would it make = more sense to leave them be, hook the directories into the build = somehow, then move them over to their respective spots once they=92ve = been converted over? I was trying to keep things relatively pristine when dealing with the = NetBSD testcases as well so it would be clearer which was =93our=92s=94 = and what was =93their=92s=94, mostly because the code isn=92t checked = into a vendor tree as I don=92t have a commit bit and no one else with a = commit bit has done it yet. Thanks! -Garrett=