From owner-cvs-usrbin  Thu Aug 28 15:18:15 1997
Return-Path: <owner-cvs-usrbin>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id PAA23866
          for cvs-usrbin-outgoing; Thu, 28 Aug 1997 15:18:15 -0700 (PDT)
Received: from mail.cs.tu-berlin.de (root@mail.cs.tu-berlin.de [130.149.17.13])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id PAA23855;
          Thu, 28 Aug 1997 15:18:04 -0700 (PDT)
Received: from panke.panke.de (anonymous219.ppp.cs.tu-berlin.de [130.149.17.219])
	by mail.cs.tu-berlin.de (8.8.6/8.8.6) with ESMTP id AAA23109;
	Fri, 29 Aug 1997 00:04:46 +0200 (MET DST)
Received: (from wosch@localhost) by panke.panke.de (8.8.5/8.6.12) id XAA00780; Thu, 28 Aug 1997 23:09:55 +0200 (MET DST)
To: Jun-ichiro Itoh <itojun@FreeBSD.ORG>
Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-usrbin@FreeBSD.ORG,
        Ulrich Drepper <drepper@ipd.info.uni-karlsruhe.de>,
        joerg_wunsch@uriah.heep.sax.de
Subject: Re: cvs commit: src/usr.bin/shar shar.sh
References: <199708281435.HAA14141@freefall.freebsd.org>
From: Wolfram Schneider <wosch@apfel.de>
Date: 28 Aug 1997 23:09:53 +0200
In-Reply-To: Jun-ichiro Itoh's message of Thu, 28 Aug 1997 07:35:10 -0700 (PDT)
Message-ID: <p1ik9h6m2u6.fsf@panke.panke.de>
Lines: 47
Sender: owner-cvs-usrbin@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

Jun-ichiro Itoh <itojun@FreeBSD.ORG> writes:
> itojun      1997/08/28 07:35:09 PDT
>   Modified files:
>     usr.bin/shar         shar.sh 
>   Log:
>   To cope with shell archive file generated by GNU sharutils 4.2.
>   (it assumes that shar will bark if there's invalid argument specified)
>   
>   Patch suggested by Ulrich Drepper <drepper@ipd.info.uni-karlsruhe.de>.
>   
>   Reviewed by:	joerg_wunsch@uriah.heep.sax.de
>   
>   Revision  Changes    Path
>   1.2       +10 -2     src/usr.bin/shar/shar.sh

The patch is not complete. shar(1) still exit with value
zero even a file is not readable.

$ touch /tmp/shar
$ chmod 0000 /tmp/shar 
$ sh shar.sh /tmp/shar > /dev/null 
sed: /tmp/shar: Permission denied
$ echo $?
0


Alternative patch:

Index: shar.sh
===================================================================
RCS file: /usr/cvs/src/usr.bin/shar/shar.sh,v
retrieving revision 1.1
diff -u -r1.1 shar.sh
--- shar.sh	1994/05/27 12:32:39	1.1
+++ shar.sh	1997/08/28 20:50:08
@@ -64,7 +64,7 @@
 	else
 		echo "echo x - $i"
 		echo "sed 's/^X//' >$i << 'END-of-$i'"
-		sed 's/^/X/' $i
+		sed 's/^/X/' $i || exit
 		echo "END-of-$i"
 	fi
 done

-- 
Wolfram Schneider   <wosch@apfel.de>   http://www.apfel.de/~wosch/