From owner-svn-src-all@freebsd.org Tue Mar 12 10:50:25 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 82567152ACCA; Tue, 12 Mar 2019 10:50:25 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 24677889A5; Tue, 12 Mar 2019 10:50:25 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 10D8B8AE1; Tue, 12 Mar 2019 10:50:25 +0000 (UTC) Date: Tue, 12 Mar 2019 10:50:25 +0000 From: Alexey Dokuchaev To: Harry Schmalzbauer Cc: Mateusz Piotrowski <0mp@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r345057 - head/share/man/man7 Message-ID: <20190312105025.GA54467@FreeBSD.org> References: <201903120927.x2C9Rc1B017630@repo.freebsd.org> <79a9c91f-72c2-ef18-e341-4ed471fb787c@omnilan.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <79a9c91f-72c2-ef18-e341-4ed471fb787c@omnilan.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 24677889A5 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_SHORT(-0.94)[-0.942,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2019 10:50:25 -0000 On Tue, Mar 12, 2019 at 11:17:58AM +0100, Harry Schmalzbauer wrote: > Am 12.03.2019 um 10:27 schrieb Mateusz Piotrowski: > > New Revision: 345057 > > URL: https://svnweb.freebsd.org/changeset/base/345057 > > > > Log: > > ports.7: Add an example of how to use flavors > > Since cem and dim seem to stumbled over the missing FLAVOR > documentation, I see my main objection against current FLAVOR > implementation confirmed: build stage must'nt silently chose a > default FLAVOR, but an OPTIONS-like dialog must inform the user > and she _must_ choose one. > > FLAVOR is a severe regression for ports usage to all FreeBSD > users imho. Users can't see if a port makes use of FLAVOR or not. > User won't get informed that default FLAVOR is in use. [...] Users who install packages that are built from a flavorized port are well informed which flavor they're about to install, I don't see how flavors cause a problem -- they must have unique PKGNAMEs. For users that are building ports by themselves, looking into a Makefile can be helpful, but then again -- don't we always do that? It might slip when building the dependencies, so yeah, some extra care is in order. I don't see what's a big deal here, and flavors are certainly less annoying and more flexible than slave ports. If you really want an OPTIONS-like dialog popup then perhaps you should've attached some patches to your complaints. :-) ./danfe