From owner-svn-ports-all@FreeBSD.ORG  Mon Dec 10 09:09:29 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 93DD4A9E;
 Mon, 10 Dec 2012 09:09:29 +0000 (UTC)
 (envelope-from gahr@FreeBSD.org)
Received: from cpanel09.rubas.ch (cpanel09.rubas.ch [195.182.222.79])
 by mx1.freebsd.org (Postfix) with ESMTP id 3CF038FC17;
 Mon, 10 Dec 2012 09:09:29 +0000 (UTC)
Received: from 98-41.199-178.cust.bluewin.ch ([178.199.41.98]:63873
 helo=gahrfit.gahr.ch)
 by cpanel09.rubas.ch with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256)
 (Exim 4.80) (envelope-from <gahr@FreeBSD.org>)
 id 1ThzMd-003tgz-NS; Mon, 10 Dec 2012 10:09:28 +0100
Date: Mon, 10 Dec 2012 10:09:24 +0100
From: Pietro Cerutti <gahr@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r308484 - head/textproc/idnits
Message-ID: <20121210090924.GA33683@gahrfit.gahr.ch>
References: <201212081626.qB8GQX0v075317@svn.freebsd.org>
 <20121210084822.GD34139@FreeBSD.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="BXVAT5kNtrzKuDFl"
Content-Disposition: inline
In-Reply-To: <20121210084822.GD34139@FreeBSD.org>
X-PGP-Key: 0x9571F78E
X-PGP-Fingerprint: 1203 92B5 3919 AF84 9B97 28D6 C0C2 6A98 9571 F78E
User-Agent: Mutt/1.5.21 (2010-09-15)
X-AntiAbuse: This header was added to track abuse,
 please include it with any abuse report
X-AntiAbuse: Primary Hostname - cpanel09.rubas.ch
X-AntiAbuse: Original Domain - freebsd.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - FreeBSD.org
X-Get-Message-Sender-Via: cpanel09.rubas.ch: authenticated_id: gahr@gahr.ch
Cc: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>, svn-ports-head@freebsd.org,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: gahr@FreeBSD.org
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Dec 2012 09:09:29 -0000


--BXVAT5kNtrzKuDFl
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2012-Dec-10, 08:48, Alexey Dokuchaev wrote:
> On Sat, Dec 08, 2012 at 04:26:32PM +0000, Sunpoet Po-Chuan Hsieh wrote:
> > New Revision: 308484
> > URL: http://svnweb.freebsd.org/changeset/ports/308484
> >=20
> >  post-patch:
> > -	@${REINPLACE_CMD} -e '1 s|^#!/bin/bash|#!${LOCALBASE}/bin/bash|' \
> > -		${WRKSRC}/${PORTNAME}
> > +	@${REINPLACE_CMD} -e '1 s|^#!/bin/bash|#!${LOCALBASE}/bin/bash|' ${WR=
KSRC}/${PORTNAME}
>=20
> Do you mind backing this hunk out?  Previous version was much better (mos=
t of
> us still use standard 80-char wide xterms).

What about we *first* document somewhere that line width must be <=3D 80
(or 76, fwiw) and *then* try to enforce it on others' commits?

Not that I'm against it in principle, but I don't feel comfortable with
you making law out of your personal preference.


--=20
Pietro Cerutti
The FreeBSD Project
gahr@FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp

--BXVAT5kNtrzKuDFl
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlDFpsMACgkQwMJqmJVx945kzgCbBcadM6jVYc774lt7k6Qp0CWx
5BYAoLYSxs+9D768syf+dBoTGchsGmzO
=ySFl
-----END PGP SIGNATURE-----

--BXVAT5kNtrzKuDFl--