From owner-svn-src-head@freebsd.org Tue Mar 21 20:23:26 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2EDD2CD7EA3; Tue, 21 Mar 2017 20:23:26 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id CB565BE9; Tue, 21 Mar 2017 20:23:25 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id qQJNcBODBC3JIqQJOccE83; Tue, 21 Mar 2017 14:23:24 -0600 X-Authority-Analysis: v=2.2 cv=XbT59Mx5 c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=6Iz7jQTuP9IA:10 a=KawIFhhbAAAA:8 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=vsL1ZULAZ7TolKXOxSoA:9 a=CjuIK1q_8ugA:10 a=Ijv1rhU9Br0A:10 a=sDZbbUVwIjaXAAecbMhh:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id 016F31F9F; Tue, 21 Mar 2017 13:23:20 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v2LKNK7o098584; Tue, 21 Mar 2017 13:23:20 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201703212023.v2LKNK7o098584@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Slawa Olhovchenkov cc: Cy Schubert , svn-src-head@freebsd.org, svn-src-all@freebsd.org, Gleb Smirnoff , src-committers@freebsd.org, John Baldwin Subject: Re: svn commit: r315662 - in head: contrib/bsnmp/snmp_mibII contrib/ipfilter/ipsend lib/libprocstat sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat usr.bin/systat usr.sbin/tcpdrop usr.sbin/trpt In-Reply-To: Message from Slawa Olhovchenkov of "Tue, 21 Mar 2017 23:18:38 +0300." <20170321201838.GG86500@zxy.spb.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 21 Mar 2017 13:23:20 -0700 X-CMAE-Envelope: MS4wfC3VE3nDpHvKZbUGDViLaD9Ex4o6R7VJLLTw2ONmwJT4GA9gZBmsWW5AxiQURUcUy6vwXudM+3hAk4xT9FjnzrZmzGXFOSIYjKqrULNltXnGW0BQqQl4 zaK4h7/laavIhHu3hXnDLJBnC4AX6i9IpjAT+vR7TBv9mVisDFod6yWoUbFnVks0ijOHOTVTCFOTUrIf/dH0QIEwpKxzffVNUtxycVSNPZxTqPLnagaILpW0 MtssvU5d/d89zxntnm2TLm7TD6R2igh2pN1Qruj90G3Q18Cfd5sW+GwPcheSiPbz1+184yHTVQ9mwIMrwcJkiupjp9jZGvmulStlZZk/s1E= X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 20:23:26 -0000 In message <20170321201838.GG86500@zxy.spb.ru>, Slawa Olhovchenkov writes: > On Tue, Mar 21, 2017 at 01:07:42PM -0700, Cy Schubert wrote: > > > In message <20170321195202.GF86500@zxy.spb.ru>, Slawa Olhovchenkov writes: > > > On Tue, Mar 21, 2017 at 11:50:04AM -0700, Gleb Smirnoff wrote: > > > > > > > John, > > > > > > > > On Tue, Mar 21, 2017 at 10:40:34AM -0700, John Baldwin wrote: > > > > J> First, this is a very good change and long overdue in divorcing the > > > > J> user-facing structure for live system reporting vs the kernel struct > ure. > > > > J> > > > > J> However, I realize you don't use info from netstat when debugging ke > rnel > > > > J> crash dumps, but other people _do_. It's ok if the kvm bits of nets > tat > > > > J> require a matching kernel and thus require recompiling everytime the > ABI > > > > J> changes, but it is useful to have them. Please restore those. > > > > > > > > I have very much anticipated this comment from you, John. > > > > > > > > I would like to remind you, that we have had this very exact conversati > on > > > > back when I removed kvm support from netstat/route.c. Let me search the > > > > archives: > > > > > > > > https://lists.freebsd.org/pipermail/svn-src-head/2015-April/070480.html > > > > > > > > This conversation has had a continuation on IRC, which I don't archive. > > > > > > > > AFAIR, first I told that with all my involvement into networking stack, > > > > I never ever had experienced a need to run route stats on a core. The > > > > debugger were the only useful tool. And that opinion was seconded by > > > > other network hackers. Then we discussed that a proper tool chould use > > > > dynamic type parsing and not kvm(3). You said that future gdb has pytho > n > > > > scripting and that would work fine. Meanwhile, you insisted that I rest > ore > > > > the functionality. I resisted to put kvm(3) back into netstat/route.c, > and > > > > instead I created a gdb script that prints exactly what 'nestat -anr -M > cor > > > e' > > > > prints. And I committed the script just to satisfy your demand: > > > > > > > > tools/debugscripts/netstat-anr.gdb > > > > > > > > Can you please fairly answer, have you (or anyone else) ever used the > > > > script during these 2 years? > > > > > > > > I believe, the inpcb/tcpcb printing from a core functionality has the > > > > same level of real usefulness. I could create the same script for pcbs, > > > > and I am afraid it is going to share fate of netstat-anr.gdb. > > > > > > How long run this script for core file w/ 40K TCP connections? > > > > Would it be possible to replace this script with new DTrace probes and a > > DTrace script? > > DTrace probes in /etc/rc.d/savecore? Realy? > Sorry, rushing through the noon hour. I should have read this thread more carefully. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.