From owner-cvs-all@FreeBSD.ORG Sat Jul 7 06:48:24 2012 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 8CE1F106566C; Sat, 7 Jul 2012 06:48:24 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from opti.dougb.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id C8FD814DC35; Sat, 7 Jul 2012 06:48:23 +0000 (UTC) Message-ID: <4FF7DBB7.1000801@FreeBSD.org> Date: Fri, 06 Jul 2012 23:48:23 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120621 Thunderbird/13.0.1 MIME-Version: 1.0 To: "George V. Neville-Neil" References: <201207062027.q66KRZD1074466@repoman.freebsd.org> <20120707043907.GA71944@dormouse.experts-exchange.com> In-Reply-To: <20120707043907.GA71944@dormouse.experts-exchange.com> X-Enigmail-Version: 1.4.2 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, Jason Helfman , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/zookeeper Makefile distinfo pkg-descr pkg-plist ports/devel/zookeeper/files patch-src-c-src-zookeeper.c zookeeper X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jul 2012 06:48:24 -0000 On 07/06/2012 21:39, Jason Helfman wrote: > On Fri, Jul 06, 2012 at 08:27:35PM +0000, George V. Neville-Neil thus > spake: >> gnn 2012-07-06 20:27:35 UTC >> >> FreeBSD ports repository (src committer) >> >> Added files: >> devel/zookeeper Makefile distinfo pkg-descr pkg-plist >> devel/zookeeper/files patch-src-c-src-zookeeper.c zookeeper >> Log: >> Initial commit of Apache Zookeeper a distributed coordination system. >> >> Approved by: skreuzer (mentor) >> >> Revision Changes Path >> 1.1 +79 -0 ports/devel/zookeeper/Makefile (new) >> 1.1 +2 -0 ports/devel/zookeeper/distinfo (new) >> 1.1 +21 -0 >> ports/devel/zookeeper/files/patch-src-c-src-zookeeper.c (new) >> 1.1 +33 -0 ports/devel/zookeeper/files/zookeeper (new) >> 1.1 +17 -0 ports/devel/zookeeper/pkg-descr (new) >> 1.1 +378 -0 ports/devel/zookeeper/pkg-plist (new) > > This seems to be broken, but I submitted a pr to fix it. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=169693 Furthermore the rc.d script is a mess, and should not have been committed like it was (numerous missing bits, bad format, set_rcvar, hard-coded /usr/local, no REQUIRE, no KEYWORD: shutdown, etc.). Please read http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html and then ask in freebsd-rc@ if you have any additional questions. Sorry to be so blunt, but I'm really, really tired of repeating the same stuff over and over again, and this script is really a mess. Also, don't install the script in do-install, see the web page above (and/or the PR) for USE_RC_SUBR. And FYI, there is no need to have the function in that script. You could use (for example) start_cmd="$command start" just as well. Not to mention that the function you have should be using $1 as the argument to $command, not $rc_arg. Reasons why left as an exercise for the reader ... Doug -- This .signature sanitized for your protection