From owner-cvs-src@FreeBSD.ORG  Fri May 21 06:40:45 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id CEB3B16A4D3; Fri, 21 May 2004 06:40:45 -0700 (PDT)
Received: from arginine.spc.org (arginine.spc.org [195.206.69.236])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1050943D1D; Fri, 21 May 2004 06:40:45 -0700 (PDT)
	(envelope-from bms@spc.org)
Received: from localhost (localhost [127.0.0.1])
	by arginine.spc.org (Postfix) with ESMTP
	id EE315653B5; Fri, 21 May 2004 14:40:41 +0100 (BST)
Received: from arginine.spc.org ([127.0.0.1])
 by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id 17259-02-2; Fri, 21 May 2004 14:40:41 +0100 (BST)
Received: from empiric.dek.spc.org (82-147-17-88.dsl.uk.rapidplay.com
	[82.147.17.88])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by arginine.spc.org (Postfix) with ESMTP
	id DE2BF653AD; Fri, 21 May 2004 14:40:40 +0100 (BST)
Received: by empiric.dek.spc.org (Postfix, from userid 1001)
	id 3F6F3612E; Fri, 21 May 2004 14:40:38 +0100 (BST)
Date: Fri, 21 May 2004 14:40:38 +0100
From: Bruce M Simpson <bms@spc.org>
To: Scott Long <scottl@freebsd.org>
Message-ID: <20040521134038.GE90068@empiric.dek.spc.org>
Mail-Followup-To: Scott Long <scottl@freebsd.org>,
	"M. Warner Losh" <imp@bsdimp.com>, src-committers@freebsd.org,
	cvs-src@freebsd.org, cvs-all@freebsd.org
References: <200405210636.i4L6aadV059034@repoman.freebsd.org>
	<40ADAF07.2070909@freebsd.org> <20040521.020412.118756775.imp@bsdimp.com>
	<40ADBC15.6040004@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <40ADBC15.6040004@freebsd.org>
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: "M. Warner Losh" <imp@bsdimp.com>
Subject: Re: cvs commit: src/sys/dev/pci pci.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 May 2004 13:40:46 -0000

On Fri, May 21, 2004 at 02:21:41AM -0600, Scott Long wrote:
> Well, the 8.3.3 paragraph only specifically mentions the command
> register and the BARs.  I'm just worried that by touching stuff outside
> of this range that you open up the risk of tickling latent buggy
> silicon.  Exception cases like the ATA hardware doing magic things with
> the progif register should be left up to the ATA driver.  It's exactly
> those kinds of bent-rules that makes me nervous =-)

Maybe this behaviour could be enabled or disabled with an instance variable?
I can think of one example of hardware which might need this. I owned an
IBM ThinkPad T22 with an xl(4) NIC for about a year, and one of the things
which annoyed me about suspend/resume was the tendency for it to lose its
PCI configuration.

Regards,
BMS