From nobody Wed Feb 25 02:09:54 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fLJ2F4zdTz6TZfh; Wed, 25 Feb 2026 02:09:57 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fLJ2F44JJz3bYr; Wed, 25 Feb 2026 02:09:57 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771985397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Hzi8lzn2GEysrMxzaKbzpKWkC9OKJ55tZ7QB3T/9qoo=; b=rrnI5SlWAsYqJzPUYo2S/QWzwRgLJ+DqSZorELpJ2G7wCZjnGMDPTX36h4305hFE71wtuI 1QMEQdaannnuavP5I7mKmPxRRY4Ma7QUtClbMb3l8ONk4CYIO6Misviyg8n0Oo4qy/VDZA core4b7tcqJuWM9oBAnz92hKOMfJUrIh1Rq9RFz0Rb4YSkJKuScdOZOBiIZyUWK/MtBAN6 7HTYxtRC+USR8+dR6I8axLx3eWIPEHMPUXL1CiqgWdfuTSUPAagxCMc305BHgjUIs6x/TH CucBMIY8ZnyiY5Dk4QyFT4x7iq1Jw/khfaqImzCRBn6joshJXIMPs1u8T/xNMA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771985397; a=rsa-sha256; cv=none; b=ArldPEG2YB2+cdX/SnaD/zbel8FqkIz49b4U5jyEi0p+MOb/mZX1P/8xexYR/7ek2bkRX+ HnSHvCe0fY/+HRChSyhk+wD6M9pHynO/UhoXLrOBFEWTWAfqbnFw9lNimbNCgIFNs8UmH+ ON21jshrhmh1g7sgUalvK/PqZZLD3Eps8Jze9jeOKkw3GkrrJjwCVoDVWNOsRL23v514E8 tWVXA5m6cMfMYavWzWv8kZwOmjJ/q7F5CnBDKI7GXPavaCVelA3T6Bs5SQ/Zw7J+G2KqdU rM0TRMjBv/LvLRiFcC7tTpCW9EXHk7SCThj+F9WQSSFjL03PbcqgNzkIozTlOQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771985397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Hzi8lzn2GEysrMxzaKbzpKWkC9OKJ55tZ7QB3T/9qoo=; b=MBe+xXNqkiXnx4VKHYibs+ee8QcXd6oqs/LXKBrg79dj2FZD5TI01+UJ4MI042GT73N+xa V4y4gHXKoz/QPVJXcqQshyTVrdZG1deKWckM3fedY8Gm98K2UjdNugJINMc/CT9PU147xx iFMEgsYPHk2EDSEMASgOAorcAzCXO+jIBnijaIf/WCfRErutHx88IJ/uQ5tBkpIfCeNTMC RdAP/p9//Mp76AIY/e4bM272f4aUmGa7h8XvRY0HZyCyTK9NcG9uIyCLxR1F/6HnoQuJJs 7qRVckmr2TxLVc0qAObn7XxAgApXas73e1+K5Jgcx8bXREYd5MQixk/Iz0x+oQ== Received: from mx-01.divo.sbone.de (legacy1.sbone.de [80.151.10.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E7" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fLJ2F2QTMz143C; Wed, 25 Feb 2026 02:09:57 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id E8FE3A64808; Wed, 25 Feb 2026 02:09:36 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id A8B4F2D029D8; Wed, 25 Feb 2026 02:09:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id 9VZQORp6rFJE; Wed, 25 Feb 2026 02:09:54 +0000 (UTC) Received: from nv.t4-02.sbone.de (nv.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 377B62D029E8; Wed, 25 Feb 2026 02:09:54 +0000 (UTC) Date: Wed, 25 Feb 2026 02:09:54 +0000 (UTC) From: "Bjoern A. Zeeb" To: John Baldwin cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 5edf24aac1d0 - main - ofed: reduce usage of struct dma_attrs *dma_attrs In-Reply-To: Message-ID: References: <699e2185.37782.5dbfa03b@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Tue, 24 Feb 2026, John Baldwin wrote: > On 2/24/26 17:09, Bjoern A. Zeeb wrote: >> The branch main has been updated by bz: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=5edf24aac1d0978d37d62594f42d87c9f118622b >> >> commit 5edf24aac1d0978d37d62594f42d87c9f118622b >> Author: Bjoern A. Zeeb >> AuthorDate: 2026-02-19 23:12:29 +0000 >> Commit: Bjoern A. Zeeb >> CommitDate: 2026-02-24 22:04:36 +0000 >> >> ofed: reduce usage of struct dma_attrs *dma_attrs >> ib_verbs.h still uses struct dma_attrs *dma_attrs everywhere. >> It is beyond my knowledge when that struct got deprecated upstream but >> it is still supported by our LinuxKPI. The problem is that the >> functions called with that argument (dma_map_single_attrs, >> dma_unmap_single_attrs, dma_map_sg_attrs, dma_unmap_sg_attrs) so far >> are #defines in LinuxKPI and drop the last argument (attrs) so it was >> never a problem. >> In preparation to pass the attrs to the actual implementation in >> LinuxKPI, >> which has gained support for them, we now pass dma_sttrs->flags which >> is the expected unsigned long bit field. >> If anyone has serious interest in updating our ofed >> implementation they >> could look into this some more and remove the usage of struct >> dma_attrs >> entirely. > > I already have. It's buried in this branch that I still need to get wider > testing (and I'm not sure yet I've backported all the things I need): > > https://github.com/freebsd/freebsd-src/compare/main...bsdjhb:freebsd:ofed_backports > > Notably, early in the branch are these two commits: > > https://github.com/freebsd/freebsd-src/commit/a4583c049091d6468593fb04c1fc23c18195666f > (cherry-pick of an old Linux commit) Thank you! > and then: > > https://github.com/freebsd/freebsd-src/commit/788fb6bf0e6f3aa33aaf7dba362c44f1092a3559 Ah nice. You made me check when this happend upstream and I found 00085f1efa387 . Seems this was v4.8 so that should not be a problem to ditch dma-attrs.h then :) Thank you! I'll be happy to help review changes if needed, especially for all things concerning LinuxKPI (or in case you hit that netdevice). /bz -- Bjoern A. Zeeb r15:7