From owner-cvs-ports@FreeBSD.ORG Wed Jul 2 22:50:53 2008 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 68BBD106566C; Wed, 2 Jul 2008 22:50:53 +0000 (UTC) (envelope-from kozlov@ravenloft.kiev.ua) Received: from istc.kiev.ua (wolf.istc.kiev.ua [193.108.236.1]) by mx1.freebsd.org (Postfix) with ESMTP id 1F3DB8FC13; Wed, 2 Jul 2008 22:50:53 +0000 (UTC) (envelope-from kozlov@ravenloft.kiev.ua) Received: from [91.123.146.100] (helo=ravenloft.kiev.ua) by istc.kiev.ua with esmtp (Exim 4.52) id 1KEAes-0006F1-2q; Thu, 03 Jul 2008 01:18:40 +0300 Received: from kozlov by ravenloft.kiev.ua with local (Exim 4.69 (FreeBSD)) (envelope-from ) id 1KEAer-0001X1-Ni; Thu, 03 Jul 2008 01:18:37 +0300 Date: Thu, 3 Jul 2008 01:18:37 +0300 From: Alex Kozlov To: Alexey Dokuchaev , Rong-En Fan , cvs-ports@FreeBSD.org, spam@rm-rf.kiev.ua Message-ID: <20080702221837.GA5612@ravenloft.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: Alex Kozlov X-Spam-Score: 0.0 (/) X-Spam-Report: Content analysis detailz: (0.0 points, 10.0 required) Cc: Subject: Re: cvs commit: ports/www/lynx Makefile pkg-plist X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jul 2008 22:50:53 -0000 On Wed, Jul 02, 2008 at 09:16:05PM +0000, Alexey Dokuchaev wrote: > On Wed, Jul 02, 2008 at 02:57:56PM +0000, Rong-En Fan wrote: > > rafan 2008-07-02 14:57:56 UTC > > > > FreeBSD ports repository > > > > Modified files: > > www/lynx Makefile pkg-plist > > Log: > > - Use ncursesw if available > > - Use gzip for documents > > - OPTIONS'ify > > - Bump PORTREVISION This is backport from lynx-current. > I have a couple of questions: > > - Is CONFIGURE_TARGET really necessary here? Is yes, could you elaborate > on why whould it be? > - Exatra parameter --enable-nested-tables was added to CONFIGURE_ARGS, > but commit log does not mention it. What changes does it bring? It's allow to show table in table. By default lynx show only inner tables in that case. In my opinion this is quite safe option. Sorry for not mention it in description. > - In OPTIONS, "Colors support" does not look very descriptive to me > - Again in OPTIONS, "IPV6 support" should probably be speeled as IPv6 > - OPTIONS are badly indented > - .if defined(WITH_IPV6) && ! defined(NO_INET6) -- superfluous space > after ! > - ENABLE_DEFAULT_COLORS should probably be dropped altogether (with > corresponding UPDARING note): we should not encourage non-standard > knobs (i.e. not starting with WITH/WITHOUT) in most cases I agree, but someone may still have this knob in make.conf. May be best course of action will be warning and then dropping knob in next update. > This is just what cathes the eye, it's not thorough review. -- Adios