Date: Mon, 04 Jan 2016 22:15:45 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 205905] devel/binutils Makefile has wrong COMPILER_VERSION check Message-ID: <bug-205905-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D205905 Bug ID: 205905 Summary: devel/binutils Makefile has wrong COMPILER_VERSION check Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: bapt@FreeBSD.org Reporter: markmi@dsl-only.net Flags: maintainer-feedback?(bapt@FreeBSD.org) Assignee: bapt@FreeBSD.org Line 58 of (/usr/ports -r404557) /user/ports/devel/binutils/Makefile is: .if ${ARCH} !=3D ia64 && ${ARCH} !=3D mips && ${ARCH} !=3D mips64 && !defined(PKGNAMEPREFIX) && (${COMPILER_TYPE} =3D=3D clang && ${COMPILER_VER= SION} >=3D 34 || ${COMPILER_TYPE} =3D=3D gcc) Comparing that to /usr/src/share/mk/bsd.compiler.mk notation: .if ${COMPILER_TYPE} =3D=3D "clang" || \ (${COMPILER_TYPE} =3D=3D "gcc" && ${COMPILER_VERSION} >=3D 40800) /user/ports/devel/binutils/Makefile has the wrong scale of numbers for the version check. (It also does not use the quotes syntax for the string literals in the stri= ng comparisons if that ever matters.) /usr/src/share/mk/bsd.compiler.mk has: _v!=3D ${CC} --version || echo 0.0.0 . . . .if !defined(COMPILER_VERSION) COMPILER_VERSION!=3Decho ${_v:M[1-9].[0-9]*} | awk -F. '{print $$1 * 10000 = + $$2 * 100 + $$3;}' .endif confirming the larger numbers as the normal encoding in COMPILER_VERSION as produced by bsd.compiler.mk . --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-205905-13>