From owner-freebsd-arch@FreeBSD.ORG Wed Jan 21 14:36:43 2009 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 32EEE1065679; Wed, 21 Jan 2009 14:36:43 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id EE6D48FC1F; Wed, 21 Jan 2009 14:36:42 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (pool-98-109-39-197.nwrknj.fios.verizon.net [98.109.39.197]) by cyrus.watson.org (Postfix) with ESMTPSA id 9A6B746B17; Wed, 21 Jan 2009 09:36:42 -0500 (EST) Received: from localhost (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.3/8.14.3) with ESMTP id n0LEaaWp033642; Wed, 21 Jan 2009 09:36:36 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Andriy Gapon Date: Wed, 21 Jan 2009 09:36:28 -0500 User-Agent: KMail/1.9.7 References: <496C8C6A.2030708@icyb.net.ua> <200901210857.22204.jhb@freebsd.org> <49772F44.1030806@icyb.net.ua> In-Reply-To: <49772F44.1030806@icyb.net.ua> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200901210936.28773.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 21 Jan 2009 09:36:36 -0500 (EST) X-Virus-Scanned: ClamAV 0.94.2/8884/Wed Jan 21 08:15:32 2009 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Archie Cobbs , freebsd-arch@freebsd.org Subject: Re: smb(4): address format X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2009 14:36:49 -0000 On Wednesday 21 January 2009 9:20:52 am Andriy Gapon wrote: > on 21/01/2009 15:57 John Baldwin said the following: > > On Friday 16 January 2009 8:17:26 am Andriy Gapon wrote: > >> on 15/01/2009 20:08 M. Warner Losh said the following: > >>> The format that is preferred on FreeBSD is xxxxxxxx0b. That's the > >>> format that the existing IIC bridge drivers use and deal with. I've > >>> not looked at the SMB drivers, but I went through all the iic bridge > >>> drivers in the 6.x time frame and made sure they were all consistent. > >>> If I missed the smb drivers, that's my bad. > >>> > >>> I could find no evidence that there was a format that was more > >>> preferred apart from the dozen data sheets that I'd read at the time > >>> which used the xxxxxxx0b. > >> What about the attached patch. > >> It brings ichsmb in line with this format and also adds a simple check > >> into smb(4). > > > > Commit! > > > > I guess this would also need a note in UPDATING and some HEADS UP in > current@. Sure, though I had a hard time getting people to test the locking changes to the smbus(4) drivers, so I doubt many current@ users actually use smbus(4). -- John Baldwin