Date: Fri, 17 Dec 2021 22:00:07 GMT From: John Baldwin <jhb@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 49bb13076532 - main - cryptosoft: Remove unused 'iv' in swcr_ccm_cbc_mac. Message-ID: <202112172200.1BHM07tV005999@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=49bb13076532ec9a24ea26cf0c9c4649641c8ea8 commit 49bb13076532ec9a24ea26cf0c9c4649641c8ea8 Author: John Baldwin <jhb@FreeBSD.org> AuthorDate: 2021-12-17 21:58:58 +0000 Commit: John Baldwin <jhb@FreeBSD.org> CommitDate: 2021-12-17 21:58:58 +0000 cryptosoft: Remove unused 'iv' in swcr_ccm_cbc_mac. Reviewed by: markj Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D33525 --- sys/opencrypto/cryptosoft.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/opencrypto/cryptosoft.c b/sys/opencrypto/cryptosoft.c index 62dae55f1537..6f03902498b1 100644 --- a/sys/opencrypto/cryptosoft.c +++ b/sys/opencrypto/cryptosoft.c @@ -624,7 +624,6 @@ build_ccm_aad_length(u_int aad_length, uint8_t *blk) static int swcr_ccm_cbc_mac(const struct swcr_session *ses, struct cryptop *crp) { - u_char iv[AES_BLOCK_LEN]; u_char blk[CCM_CBC_BLOCK_LEN]; u_char tag[AES_CBC_MAC_HASH_LEN]; union authctx ctx; @@ -645,7 +644,6 @@ swcr_ccm_cbc_mac(const struct swcr_session *ses, struct cryptop *crp) /* Initialize the IV */ ivlen = csp->csp_ivlen; - crypto_read_iv(crp, iv); /* Supply MAC with IV */ axf->Reinit(&ctx, crp->crp_iv, ivlen); @@ -679,7 +677,6 @@ swcr_ccm_cbc_mac(const struct swcr_session *ses, struct cryptop *crp) } explicit_bzero(tag, sizeof(tag)); explicit_bzero(blk, sizeof(blk)); - explicit_bzero(iv, sizeof(iv)); return (error); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202112172200.1BHM07tV005999>