Date: Thu, 13 Apr 1995 08:43:24 +1000 From: Bruce Evans <bde@zeta.org.au> To: CVS-commiters@freefall.cdrom.com, cvs-sys@freefall.cdrom.com, phk@freefall.cdrom.com Subject: Re: cvs commit: src/sys/i386/isa sio.c Message-ID: <199504122243.IAA28789@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
> Modified: sys/i386/isa sio.c > Log: > ttsetcompat is a '#ifdef COMPAT_43' feature. Actually it is a '#if defined(COMPAT_43) || defined(COMPAT_SUNOS)' misfeature. Not to mention that getty depends on ttcompat() so it isn't optional. The call to ttsetcompat() is in the wrong place and causes NULL pointer panics for access to the control devices before the corresponding real device has been opened (the control devices don't really have tty structs and the compatibility interface doesn't apply to them). > Dropping into the debugger when a break comes down the serial line is a > >MISFEATURE (1st class)< and has been put under it's own #ifdef. This > should be a magic sequence of chars instead. A magic sequence of chars would be a misfeature, as it would be for syscons. The escape should be out of bounds (perhaps it should optionally be break && some combination of the modem status lines). Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199504122243.IAA28789>