From owner-svn-src-head@FreeBSD.ORG Sun May 23 06:54:13 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CC2761065679; Sun, 23 May 2010 06:54:13 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id F05138FC19; Sun, 23 May 2010 06:54:12 +0000 (UTC) Received: by fxm4 with SMTP id 4so2403212fxm.13 for ; Sat, 22 May 2010 23:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=/SENTo6uLFc0eCLRfbhvv79gVD0h95tp4DJaeSPVaIA=; b=mROl9r2j9r2wsHxYooMkHqtOGe4fGlABgAurKWLbcqll0TYDU6FyjCysebmX7nTlQH XLhU5PHeAe4OYaaK3NTWJxgRL77kURZEgwC9fM2ZPe1hpFai8/5Ncvcxole5w0TBfhgq DopmB07IC4IbqLjrxrmlgSt9D0qzGoKPbjkbQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=hAQ82bOYDgflNGOyKAzhC9x1U0uj9T57Hs2CmeZEi1EnefeNKvKsbqWsEUFhzdN6My Nw0tOZlBG38ra5mlHCKUfyLk5e5pDU5nbFIpMKRKaTaYB4lEXi6d61OIdlrDJFL9OgnA eihxYSUK5eMlwhxNK/Xzfix+/3Amy4iVCYeP8= Received: by 10.223.56.206 with SMTP id z14mr3265329fag.97.1274597651593; Sat, 22 May 2010 23:54:11 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id r25sm13169546fai.23.2010.05.22.23.54.10 (version=SSLv3 cipher=RC4-MD5); Sat, 22 May 2010 23:54:10 -0700 (PDT) Sender: Alexander Motin Message-ID: <4BF8D0FE.4060700@FreeBSD.org> Date: Sun, 23 May 2010 09:53:50 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20091212) MIME-Version: 1.0 To: "M. Warner Losh" References: <201005170351.o4H3pvuG006399@svn.freebsd.org> <20100523.003526.1142818667088610804.imp@bsdimp.com> In-Reply-To: <20100523.003526.1142818667088610804.imp@bsdimp.com> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r208183 - in head/sys: conf modules/mvs X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 May 2010 06:54:13 -0000 M. Warner Losh wrote: > In message: <201005170351.o4H3pvuG006399@svn.freebsd.org> > Alexander Motin writes: > : Author: mav > : Date: Mon May 17 03:51:57 2010 > : New Revision: 208183 > : URL: http://svn.freebsd.org/changeset/base/208183 > : > : Log: > : Make mvs_if.c to not be always linked statically into the kernel. > : Link it same way as mvs.c. > > A consequence of this will be that if you kldload modules that use the > mvs_if.m services, but don't have the mvs.ko module, then you'll have > problems. I ran into this with pccard/pcic/pccbb/cardbus/*pccard.c > drivers so I compiled pccard_if.m into the kernel statically. > > I don't know if that's a big deal for you, but it is why things like > this are usually linked in statically. Not a big deal for now, until mvs_if.m used only inside mvs.ko itself for PCI devices or statically linked kernel for PCI/SoC. Controller driver is useless without channel driver, so probably it could be declared as dependency, if sometimes needed. I just thought it is a bit dirty to have it in a kernel when all code loaded as module. -- Alexander Motin