From nobody Tue Jun 27 09:17:10 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qqzcn26Lxz4kWs7; Tue, 27 Jun 2023 09:17:13 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qqzcn1MCgz44Kr; Tue, 27 Jun 2023 09:17:13 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687857433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dTjsc9YSN9A+qlN2DvJv4EKKhKoUq/w1gzjk6hNBn1Y=; b=lxGReQ668FTFfRniYJL+MkC+z2MgJE64Gtp/wcyRpNhY/ZWCarYGsSvwfg9FHCJRKMnqv+ sfHfrrgbBeMKArgWoUQAdSNhxG5xx2Fy3zutH+f3yW25ixoQ6g12G7/OCMZa0zEVtS1pJf m/kft+bgjoWT/qzMlqrWqdS6SLGOI8kCiy2ygQ9ErFtSKxkfOb9IG1mw5Z8ZpFosQFqgCp rP9HRqW/0Y8VnkPtcSLd3a3QwT42sHFkvMoXb9r201/hbBNZxZHQvqA5lvv6ywm1QIOBwQ a63IW3cFtscJR6AFyzQnANXcRE2ZYgTx92UXBgD2LkBVgp4XoDJWBBBp+51N4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687857433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dTjsc9YSN9A+qlN2DvJv4EKKhKoUq/w1gzjk6hNBn1Y=; b=Za2Vqxz2cIr4DEMzJnHJezE9VZZBUsxIrfdB3SAa5A2SQnljI8qhEPhPFmwNnvAWIM3iyB YI5sn6aemsSO49rxW+Yp9rdYPad8cw8/NqLwgidKUxm7LeeS2XY9d6azPfzNsLtpiPHtWZ 5HptJjz8ixbMWrutTEmQyvY4wYzsxIVdix59MV509Wj7szF0GWmeEkwkdwUVvplxQndZGz 8LNvC4qAoySpmfSxOjUakZMNdWwCSgjxm4W3mkEnLEDl0sP2mBG/V1A1d3SqrqUvsESkYB FhJ/vH9GFTpovDjQxneNu8hoZF6Grh4okbF26pyqs7F9H5LMp217G/AxlxSVIQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1687857433; a=rsa-sha256; cv=none; b=sVC2LvF8enf9wBS5HCGGeA3wzvcJRBBzkFWFeIPCZPgs7VbCJ00kTFOOTPgq8MvK4lXawl 4S1d8pbq6YyU9XqTWZ/ZdI4OB/PwuJZ67Huza0dW/pyiNRjpg+s/FUI4stdykBzjriHJ6K LPshtn3nwacapLpOkee6Ba0kyi3Q4wPPUhx9yGqCD3PpiaqZB7gEWFroJkN106xqNboYlT 0v+DwvBOgQZ3aKaOjfzrKjf+HkW1HwRo1irtRGS+tkhF0/Lu3Ukg5pooFXvrPotVK1AphD eGkIagzlgQTqylWsXwbJ0hAl/sr/0qoiLBw2SBngBuFWgCwG6EdZVuZ3cb6CEA== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Qqzcm6nDxz1JH5; Tue, 27 Jun 2023 09:17:12 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 26DB0EED6; Tue, 27 Jun 2023 11:17:11 +0200 (CEST) From: Kristof Provost To: Warner Losh , Sumit Saxena Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 91fcacc35597 - main - if_bnxt: Add support for VLAN on Thor Date: Tue, 27 Jun 2023 11:17:10 +0200 X-Mailer: MailMate (1.14r5937) Message-ID: <419530F4-DB8F-46EA-BF45-C130BCF8A3DE@FreeBSD.org> In-Reply-To: <202211042255.2A4MtqVv032693@gitrepo.freebsd.org> References: <202211042255.2A4MtqVv032693@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_MailMate_7EE3E919-6334-4664-B618-2D7388FA5076_=" X-ThisMailContainsUnwantedMimeParts: N --=_MailMate_7EE3E919-6334-4664-B618-2D7388FA5076_= Content-Type: text/plain; format=flowed Content-Transfer-Encoding: quoted-printable On 4 Nov 2022, at 23:55, Warner Losh wrote: > The branch main has been updated by imp: > > URL: = > https://cgit.FreeBSD.org/src/commit/?id=3D91fcacc355971f74aa26fc7861020= dc3a2a2d717 > > commit 91fcacc355971f74aa26fc7861020dc3a2a2d717 > Author: Sumit Saxena > AuthorDate: 2022-11-04 22:24:32 +0000 > Commit: Warner Losh > CommitDate: 2022-11-04 22:24:32 +0000 > > if_bnxt: Add support for VLAN on Thor > > Reviewed by: imp > Differential Revision: https://reviews.freebsd.org/D36443 > --- > sys/dev/bnxt/bnxt.h | 3 +- > sys/dev/bnxt/bnxt_hwrm.c | 110 = > ++++++++++++++++++++++++++++------------------- > sys/dev/bnxt/bnxt_hwrm.h | 7 ++- > sys/dev/bnxt/if_bnxt.c | 7 ++- > 4 files changed, 74 insertions(+), 53 deletions(-) > This commit appears to have broken vlan on these interfaces. My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (in a = Dell T640, if that helps). A simple vlan creation on top of one: ifconfig vlan create ifconfig vlan0 vlan 201 vlandev bnxt0 Results in a loss of connectivity. The kernel logs this, which I assume = is related: `bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_PARAMS error.` After reverting this (and 72e9dbb58cad5262190cf2eae47f764021072128) I = can create vlan interfaces on top of bnxt0 without losing connectivity. Best regards, Kristof --=_MailMate_7EE3E919-6334-4664-B618-2D7388FA5076_= Content-Type: text/html Content-Transfer-Encoding: quoted-printable

On 4 Nov 2022, at 23:55, Warner Losh wrote:

The branch main has been updated by= imp:

URL: https://cgit.FreeBSD.org/src/co= mmit/?id=3D91fcacc355971f74aa26fc7861020dc3a2a2d717

commit 91fcacc355971f74aa26fc7861020dc3a2a2d717
Author: Sumit Saxena <sumit.saxena@broadcom.com>
AuthorDate: 2022-11-04 22:24:32 +0000
Commit: Warner Losh <imp@FreeBSD.org>
CommitDate: 2022-11-04 22:24:32 +0000

if_bnxt: Add support for VLAN on Thor

Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D36443
---
sys/dev/bnxt/bnxt.h | 3 +-
sys/dev/bnxt/bnxt_hwrm.c | 110 ++++++++++++++++++++++++++++-------------= ------
sys/dev/bnxt/bnxt_hwrm.h | 7 ++-
sys/dev/bnxt/if_bnxt.c | 7 ++-
4 files changed, 74 insertions(+), 53 deletions(-)


This commit appears to have broken vlan on these interfac= es.
My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (in a = Dell T640, if that helps).

A simple vlan creation on top of one:
ifconfig vlan create
ifconfig vlan0 vlan 201 vlandev bnxt0

Results in a loss of connectivity. The kernel logs this, = which I assume is related:

bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_PARAMS erro= r.

After reverting this (and 72e9dbb58cad5262190cf2eae47f764= 021072128) I can create vlan interfaces on top of bnxt0 without losing co= nnectivity.

Best regards,
Kristof

--=_MailMate_7EE3E919-6334-4664-B618-2D7388FA5076_=--