From owner-freebsd-bugs@freebsd.org Fri May 14 12:03:58 2021 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DABA564389D for ; Fri, 14 May 2021 12:03:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4FhRyQ5gC2z3NW3 for ; Fri, 14 May 2021 12:03:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id C272A64345C; Fri, 14 May 2021 12:03:58 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C238764376E for ; Fri, 14 May 2021 12:03:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FhRyQ557Cz3NH3 for ; Fri, 14 May 2021 12:03:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A16BF11F1F for ; Fri, 14 May 2021 12:03:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 14EC3wlp055290 for ; Fri, 14 May 2021 12:03:58 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 14EC3wWi055289 for bugs@FreeBSD.org; Fri, 14 May 2021 12:03:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 255870] [PATCH] rpc/rpcsec_gss: Fix a double free in rpc_gss_marshal Date: Fri, 14 May 2021 12:03:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: lylgood@foxmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 May 2021 12:03:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255870 Bug ID: 255870 Summary: [PATCH] rpc/rpcsec_gss: Fix a double free in rpc_gss_marshal Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: lylgood@foxmail.com Created attachment 224934 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D224934&action= =3Dedit assigns verf.oa_base to checksum.value back Bug File: sys/rpc/rpcsec_gss/rpcsec_gss.c In function rpc_gss_marshal, checksum.value is assigned to verf.oa_base at = line 591. Then verf.oa_base is freed via xdr_opaque_auth()->xdr_bytes()->mem_fre= e(), and verf.oa_base is set to NULL. Notice that, checksum.value is a dangling pointer now which points to a freed memory object. Then gss_release_buffer() at line 595 is called, and the memory object poin= ted by checksum.value is freed via free() again. As verf.oa_base is set to NULL if verf.oa_base is freed, so, my patch assig= ns verf.oa_base to checksum.value back. If the verf.oa_base is freed, the valu= e of checksum.value will be NULL and no double free happens. --=20 You are receiving this mail because: You are the assignee for the bug.=