From owner-freebsd-current@FreeBSD.ORG Fri Jan 9 11:27:06 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5C184106566B for ; Fri, 9 Jan 2009 11:27:06 +0000 (UTC) (envelope-from unixmania@gmail.com) Received: from mail-fx0-f26.google.com (mail-fx0-f26.google.com [209.85.220.26]) by mx1.freebsd.org (Postfix) with ESMTP id 5FFE08FC22 for ; Fri, 9 Jan 2009 11:27:05 +0000 (UTC) (envelope-from unixmania@gmail.com) Received: by fxm7 with SMTP id 7so1805121fxm.19 for ; Fri, 09 Jan 2009 03:27:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type:references; bh=JhwTH2XGxahLcUwppJoyFazssnxcjcArSHBXJtSmUCE=; b=HKtfVGkBcWhWzq2jpmS9PSKuzc/aIlrZGRR/OJpVzl9qvOQbExmGqwyraPvzEqws+5 FfidHhY0URpPtsNlUFQ753Ly5pLxZs9Lld0mhox1WXc+DnFmI64aB8nE51KZNsYsezIk ia/cC3DamCKNmBffjrJlTI94mw/7BO9b31mQw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:references; b=bU2dukpNtNyP3voueL8YfOEW5FKWoCVcRAke5IzOYfbJYCyVQZKCQwuKlhpKmg7Sw6 qoFA5BpYP2GpDBEWqpQjJiju3zZ/UorC8gj7HmjSP448UQVMdDFYWOTTp8WjyZYqawgQ l7EikpAk5ShGDhWZzR2LKtiQq16w0JbLJ1e9Y= Received: by 10.103.182.3 with SMTP id j3mr9140323mup.113.1231500424175; Fri, 09 Jan 2009 03:27:04 -0800 (PST) Received: by 10.103.137.8 with HTTP; Fri, 9 Jan 2009 03:27:04 -0800 (PST) Message-ID: Date: Fri, 9 Jan 2009 09:27:04 -0200 From: "Carlos A. M. dos Santos" To: "Giorgos Keramidas" In-Reply-To: <87prixz9ne.fsf@kobe.laptop> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_147700_25352261.1231500424172" References: <87prixz9ne.fsf@kobe.laptop> Cc: Alexander Best , freebsd-current@freebsd.org, sos@freebsd.org Subject: Re: patch to fix burncd bug X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jan 2009 11:27:07 -0000 ------=_Part_147700_25352261.1231500424172 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On Thu, Jan 8, 2009 at 8:59 PM, Giorgos Keramidas wrote: > On Thu, 08 Jan 2009 18:13:14 +0100 (CET), Alexander Best wrote: >> could somebody please commit the following patch to dev/ata? it fixes >> a nasty bug during fixation in burncd. the bug exists in RELENG6, >> RELENG7 and HEAD (and maybe RELENG5): >> >> http://www.freebsd.org/cgi/query-pr.cgi?prp=95979-3-txt&n=/patch >> >> the whole PR can be found here: >> http://www.freebsd.org/cgi/query-pr.cgi?pr=95979 > > I think Soren is the best person to look into this bug (Cc: added). > > Soren, what do you think? Does the patch at bin/95979 look like a nice > change to commit? I just saw this PR so I haven't tried the patch on my > laptop's CURRENT yet, but I can confirm that burning CD-ROMs and DVDs is > busted in my laptop for a few weeks now. I proposed a solution a similar problem (bin/123693), but patching burncd instead of the kernel. I'm attaching the patch, for your convenience. -- cd /usr/ports/sysutils/life make clean ------=_Part_147700_25352261.1231500424172 Content-Type: text/x-diff; name=burncd_eject.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_fpqrhhzs0 Content-Disposition: attachment; filename=burncd_eject.patch ZGlmZiAtZHVyUCBidXJuY2Qub3JpZy9idXJuY2QuYyBidXJuY2QvYnVybmNkLmMKLS0tIGJ1cm5j ZC5vcmlnL2J1cm5jZC5jCTIwMDUtMDUtMTMgMTc6MDY6NDQuMDAwMDAwMDAwIC0wMzAwCisrKyBi dXJuY2QvYnVybmNkLmMJMjAwOC0wNS0yNiAwMDo1MTozMS4wMDAwMDAwMDAgLTAzMDAKQEAgLTQ2 LDYgKzQ2LDcgQEAKICNpbmNsdWRlIDxhcnBhL2luZXQuaD4KIAogI2RlZmluZSBCTE9DS1MJMTYK KyNkZWZpbmUgRUpFQ1RfVFJJRVMgNQogCiBzdHJ1Y3QgdHJhY2tfaW5mbyB7CiAJaW50CWZpbGU7 CkBAIC0zMTYsOSArMzE3LDE1IEBACiAJCWVycihFWF9JT0VSUiwgImlvY3RsKENEUklPQ1NFVEJM T0NLU0laRSkiKTsKIAl9CiAKLQlpZiAoZWplY3QpCi0JCWlmIChpb2N0bChmZCwgQ0RJT0NFSkVD VCkgPCAwKQorCWlmIChlamVjdCkgeworCQlpbnQgc3RhdHVzLCB0cnkgPSBFSkVDVF9UUklFUywg ZGVsYXkgPSAxOworCQl3aGlsZSAoKHN0YXR1cyA9IGlvY3RsKGZkLCBDRElPQ0VKRUNUKSkgPCAw ICYmIC0tdHJ5ID4gMCkgeworCQkJc2xlZXAoZGVsYXkpOworCQkJZGVsYXkgKj0gMjsKKwkJfQor CQlpZiAoc3RhdHVzIDwgMCkKIAkJCWVycihFWF9JT0VSUiwgImlvY3RsKENESU9DRUpFQ1QpIik7 CisJfQogCWNsb3NlKGZkKTsKIAlleGl0KEVYX09LKTsKIH0KT25seSBpbiBidXJuY2Qub3JpZzog YnVybmNkLmMub3JpZwo= ------=_Part_147700_25352261.1231500424172--