From owner-freebsd-current@FreeBSD.ORG Tue Jun 10 12:15:17 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E7AC37B404; Tue, 10 Jun 2003 12:15:17 -0700 (PDT) Received: from birch.ripe.net (birch.ripe.net [193.0.1.96]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0E08443F93; Tue, 10 Jun 2003 12:15:16 -0700 (PDT) (envelope-from marks@ripe.net) Received: from laptop.6bone.nl (cow.ripe.net [193.0.1.239]) by birch.ripe.net (8.12.9/8.11.6) with SMTP id h5AJF5RS023104; Tue, 10 Jun 2003 21:15:06 +0200 Received: (nullmailer pid 11283 invoked by uid 1000); Tue, 10 Jun 2003 19:15:05 -0000 Date: Tue, 10 Jun 2003 21:15:05 +0200 From: Mark Santcroos To: Orion Hodson Message-ID: <20030610191504.GA8927@laptop.6bone.nl> References: <20030609035127.GA36909@laptop.6bone.nl> <200306101644.h5AGiawR066527@puma.icir.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200306101644.h5AGiawR066527@puma.icir.org> User-Agent: Mutt/1.4.1i X-Handles: MS6-6BONE, MS18417-RIPE cc: current@freebsd.org cc: imp@bsdimp.com Subject: Re: Correct PCI suspend and resume operations [ was Re: cirrus ich3 doesn't work after suspend to disk ] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jun 2003 19:15:17 -0000 On Tue, Jun 10, 2003 at 09:44:36AM -0700, Orion Hodson wrote: > It looks like the pci configuration space state has been lost during > the suspend and resume. This may be because the bus has removed power > from the devices attached to it on suspend. For sure, in S4 mode the devices are powered down totally. > I've been through a cross section of drivers this morning and some > explicitly save and restore the PCI configuration state space and > others don't. The former seems like the safest path in most cases. Yes, it is absolutely necessary even. (For the reason stated above) > AFAICT, we don't common code for handling this and maybe there should > be some rather than have each driver replicate this behaviour. In general, that would of course be better. However, I don't know if the PCI layer (in this case) always knows enough. On the other side, if the device itself has to do some special things, the PCI layer could at least do the generic stuff. (Warner, will this also be covered by the stuff you are doing?) Mark -- Mark Santcroos RIPE Network Coordination Centre http://www.ripe.net/home/mark/ New Projects Group/TTM