From owner-dev-commits-src-main@freebsd.org  Mon Jun 28 22:16:29 2021
Return-Path: <owner-dev-commits-src-main@freebsd.org>
Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id E2A9E65D4C5;
 Mon, 28 Jun 2021 22:16:29 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4GDMQP5v9wz4jCn;
 Mon, 28 Jun 2021 22:16:29 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com
 [209.85.160.176])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 (Authenticated sender: kevans)
 by smtp.freebsd.org (Postfix) with ESMTPSA id AD2A5E0D2;
 Mon, 28 Jun 2021 22:16:29 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: by mail-qt1-f176.google.com with SMTP id g3so10430824qth.11;
 Mon, 28 Jun 2021 15:16:29 -0700 (PDT)
X-Gm-Message-State: AOAM530DL3GkUnEmwylmf75sfJUqR7nlDVHPU2OSCv4IT5vpFDd6EV36
 14nQApozkiB4O+DZxEV9/jJbhvnD4fIPVM2ravc=
X-Google-Smtp-Source: ABdhPJzolJ9P847TuH8gcOHrmG9VdWZREZ7bBSh14BNfdX+8dI6XuwWATr7k/58w6y9AQBFh6sZDP/NjM+/UrolUmK4=
X-Received: by 2002:ac8:6c6:: with SMTP id j6mr23332705qth.242.1624918589299; 
 Mon, 28 Jun 2021 15:16:29 -0700 (PDT)
MIME-Version: 1.0
References: <202106281537.15SFbdiG002780@gitrepo.freebsd.org>
 <CACNAnaFZe_bKAtrSzaMzJzV5F8Q3K1F1tVEAncLT9u=mEtwuiA@mail.gmail.com>
 <CAPyFy2CEp8r1zR+JL48a-0GXGP3g_kqwQ4AOWu1oPu3y-Ty16Q@mail.gmail.com>
 <CACNAnaHFiYR6_a0Ffu9avxLdJze47vJcwD56E5cUJb-474LOSQ@mail.gmail.com>
 <CAPyFy2AbMG30tAh7KXC15eVwzGwNTPjLnywzsHJ35P4vxTFg4A@mail.gmail.com>
In-Reply-To: <CAPyFy2AbMG30tAh7KXC15eVwzGwNTPjLnywzsHJ35P4vxTFg4A@mail.gmail.com>
From: Kyle Evans <kevans@freebsd.org>
Date: Mon, 28 Jun 2021 15:16:18 -0700
X-Gmail-Original-Message-ID: <CACNAnaHOkHTiqafOx+Zk5HArdNkXLsDwHmVsUg_8sMSW-4MzCA@mail.gmail.com>
Message-ID: <CACNAnaHOkHTiqafOx+Zk5HArdNkXLsDwHmVsUg_8sMSW-4MzCA@mail.gmail.com>
Subject: Re: git: 175841285e28 - main - Add deprecation notice for
 WITH_PROFILE option
To: Ed Maste <emaste@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, 
 "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>,
 dev-commits-src-main@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: dev-commits-src-main@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for the main branch of the src repository
 <dev-commits-src-main.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-main/>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Help: <mailto:dev-commits-src-main-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Jun 2021 22:16:30 -0000

On Mon, Jun 28, 2021 at 2:43 PM Ed Maste <emaste@freebsd.org> wrote:
>
> On Mon, 28 Jun 2021 at 16:01, Kyle Evans <kevans@freebsd.org> wrote:
> >
> > On Mon, Jun 28, 2021 at 12:57 PM Ed Maste <emaste@freebsd.org> wrote:
> > >
> > > How about "The PROFILE functionality is not available in .Fx 14."?
> >
> > +1, I like that.
>
> Hrm, I think I don't need a note in WITHOUT_PROFILE in fact. I added
> it originally because I thought PROFILE was on by default for all
> archs on stable branches, which would have only WITHOUT_PROFILE in
> src.conf.5. However, mips64 lacks PROFILE support so both are listed -
> thus with a note in WITH_PROFILE only we'd have:
>
>      WITHOUT_PROFILE
>              Do not build profiled libraries for use with gprof(8).
>
>              This is a default setting on mips/mips64.
>
>      WITH_PROFILE
>              Build profiled libraries for use with gprof(8).  This option is
>              deprecated and is not present in FreeBSD 14.
>
>              This is a default setting on amd64/amd64, arm/armv6, arm/armv7,
>              arm64/aarch64, i386/i386, mips/mips, powerpc/powerpc,
>              powerpc/powerpc64, riscv/riscv64 and riscv/riscv64sf.
>
> which I think is sufficient.

Oh yeah, totally; +1 to omitting it based on this.