From owner-freebsd-arch@FreeBSD.ORG  Mon Jan  9 09:23:51 2012
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: arch@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 844CF1065672;
	Mon,  9 Jan 2012 09:23:51 +0000 (UTC)
	(envelope-from truckman@FreeBSD.org)
Received: from gw.catspoiler.org (gw.catspoiler.org [75.1.14.242])
	by mx1.freebsd.org (Postfix) with ESMTP id 530AC8FC12;
	Mon,  9 Jan 2012 09:23:51 +0000 (UTC)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id q099NhEp025399;
	Mon, 9 Jan 2012 01:23:47 -0800 (PST)
	(envelope-from truckman@FreeBSD.org)
Message-Id: <201201090923.q099NhEp025399@gw.catspoiler.org>
Date: Mon, 9 Jan 2012 01:23:43 -0800 (PST)
From: Don Lewis <truckman@FreeBSD.org>
To: alfred@FreeBSD.org
In-Reply-To: <20120109061706.GC89781@elvis.mu.org>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
Cc: arch@FreeBSD.org
Subject: Re: [patch] allow crash dumps to Linux swap partitions
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jan 2012 09:23:51 -0000

On  8 Jan, Alfred Perlstein wrote:
> This is cool, it does seem to beg for a function instead of inlining
> the logic in two places in case someone wants to add even more logic
> to it.

That would be a bit messy because the two variations of this function
use different partition entry structures.

I believe that when these functions are called, geom has already tasted
the partitions, so we might be able to use a common helper function to
look for the presence of a BSD label.