From owner-cvs-all@FreeBSD.ORG  Mon Oct  3 22:33:59 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 52B6A16A41F;
	Mon,  3 Oct 2005 22:33:59 +0000 (GMT)
	(envelope-from truckman@FreeBSD.org)
Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 077B243D45;
	Mon,  3 Oct 2005 22:33:58 +0000 (GMT)
	(envelope-from truckman@FreeBSD.org)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id j93MXnvc019498;
	Mon, 3 Oct 2005 15:33:53 -0700 (PDT)
	(envelope-from truckman@FreeBSD.org)
Message-Id: <200510032233.j93MXnvc019498@gw.catspoiler.org>
Date: Mon, 3 Oct 2005 15:33:48 -0700 (PDT)
From: Don Lewis <truckman@FreeBSD.org>
To: kris@obsecurity.org
In-Reply-To: <20051003221608.GA98675@xor.obsecurity.org>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Oct 2005 22:33:59 -0000

On  3 Oct, Kris Kennaway wrote:
> On Mon, Oct 03, 2005 at 09:57:43PM +0000, Don Lewis wrote:
>> truckman    2005-10-03 21:57:43 UTC
>> 
>>   FreeBSD src repository
>> 
>>   Modified files:
>>     sys/ufs/ffs          ffs_alloc.c 
>>   Log:
>>   Initialize the inode i_flag field in ffs_valloc() to clean up any
>>   stale flag bits left over from before the inode was recycled.
>>   
>>   Without this change, a leftover IN_SPACECOUNTED flag could prevent
>>   softdep_freefile() and softdep_releasefile() from incrementing
>>   fs_pendinginodes.  Because handle_workitem_freefile() unconditionally
>>   decrements fs_pendinginodes, a negative value could be reported at
>>   file system unmount time with a message like:
>>           unmount pending error: blocks 0 files -3
>>   The pending block count in fs_pendingblocks could also be negative
>>   for similar reasons.  These errors can cause the data returned by
>>   statfs() to be slightly incorrect.  Some other cleanup code in
>>   softdep_releasefile() could also be incorrectly bypassed.
>>   
>>   MFC after:      3 days
> 
> Yeah!
> 
> This also affects 5.x, by the way.

Probably 4.x as well.  I'm planning on MFC'ing this all the way back
once it has aged sufficiently.