From owner-cvs-all Sun Jul 23 15:13: 9 2000 Delivered-To: cvs-all@freebsd.org Received: from localhost (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id A8E4837B9F8; Sun, 23 Jul 2000 15:12:40 -0700 (PDT) (envelope-from green@FreeBSD.org) Date: Sun, 23 Jul 2000 18:12:18 -0400 (EDT) From: Brian Fundakowski Feldman X-Sender: green@green.dyndns.org To: Alfred Perlstein Cc: Mike Smith , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern imgact_elf.c In-Reply-To: <20000723063005.L13979@fw.wintelcom.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, 23 Jul 2000, Alfred Perlstein wrote: > * Alfred Perlstein [000723 06:28] wrote: > > * Mike Smith [000723 01:01] wrote: > > > > I'm also concerned that you're using atomic_set_long() rather than > > > > or'ing the flag in, there doesn't seem to be a flag in vnode.h that > > > > could possibly co-exist with VTEXT but clearing all other flags > > > > introduces an unexpected side-effect. > > > > > > Er, atomic_set_long is a bit-set operation. > > > > It's still overly paranoid. > > And yet another place where we've used bad function names to describe > something. (would atomic_or_long have been so hard?) Heh, I said exactly that yesterday :) Then again, a "set" operation, being "=", is absolutely no use when the the long type is always atomic on every platform we support ;) Anyway, I discussed it with Peter and he said that taking the vnode.v_interlock was overkill for this... now that I think about it, I really want it to take the interlock like it did before. Other places that modify unlocked vnodes' flags use the interlock, and now I'm considering the fact that even if in this one place we use the atomic operations, if all the others use a simplelock() but still use non-atomic operations, the race condition isn't fixed. Bleh! > -- > -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] > "I have the heart of a child; I keep it in a jar on my desk." -- Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! / green@FreeBSD.org `------------------------------' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message