Date: Fri, 17 Jun 2005 09:54:03 -0700 From: Nate Lawson <nate@root.org> To: Martin Cracauer <cracauer@cons.org> Cc: acpi@FreeBSD.org Subject: Re: Call for testers: New acpi_ibm driver Message-ID: <42B3002B.7000002@root.org> In-Reply-To: <20050617125418.A4374@cons.org> References: <20050616180521.A86735@cons.org> <20050616225229.5A4785D08@ptavv.es.net> <20050617125418.A4374@cons.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Martin Cracauer wrote:
> All right.
>
> Appended diff makes my R40 load the module and have dev.acpi_ibm
> appear in sysctl.
>
> Index: acpi_ibm.c
> ===================================================================
> RCS file: /home/CVS-FreeBSD/src/sys/dev/acpi_support/acpi_ibm.c,v
> retrieving revision 1.6
> diff -u -r1.6 acpi_ibm.c
> --- acpi_ibm.c 10 Jun 2005 11:56:18 -0000 1.6
> +++ acpi_ibm.c 17 Jun 2005 16:54:59 -0000
> @@ -269,7 +269,7 @@
> DRIVER_MODULE(acpi_ibm, acpi, acpi_ibm_driver, acpi_ibm_devclass,
> 0, 0);
> MODULE_DEPEND(acpi_ibm, acpi, 1, 1, 1);
> -static char *ibm_ids[] = {"IBM0068", NULL};
> +static char *ibm_ids[] = {"IBM0068", "IBM0057", NULL};
>
> static void
> ibm_led(void *softc, int onoff)
Style note to committer, please sort IDs in alphabetical/numeric order.
Otherwise, looks fine.
--
Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42B3002B.7000002>