Date: Fri, 31 Dec 2010 04:34:48 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Stanislav Sedov <stas@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Pietro Cerutti <gahr@gahr.ch>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, gahr@FreeBSD.org Subject: Re: cvs commit: ports/graphics/freeimage Makefile distinfo pkg-descr ports/graphics/freeimage/files patch-Source-LibOpenJPEG_opj_malloc.h Message-ID: <20101231043448.GA92288@FreeBSD.org> In-Reply-To: <20101230161846.16ad0b3c.stas@FreeBSD.org> References: <201012200900.oBK90cfc062324@repoman.freebsd.org> <20101220103733.GA6738@FreeBSD.org> <20101220110727.GT7557@gahrfit.gahr.ch> <20101230161846.16ad0b3c.stas@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 30, 2010 at 04:18:46PM -0800, Stanislav Sedov wrote: > On Mon, 20 Dec 2010 12:07:27 +0100 > "Pietro Cerutti" <gahr@gahr.ch> mentioned: > > > > 1) I don't think anybody is interested in this pkg-descr change: you > > have done a minor rephrasing but haven't minimally changed the sense. > > I don't want to start a flame war, but why did you committed it then? > Everything changed deserves at least a small note in the commit log. It was committed because it was in my submission. I appreciate that Pietro did not omit anything from my patch regardless of how important or not one particular change might seem, but I also agree that every change should be at least mentioned in the commit log, with corresponding rationale in non-obvious cases. On the related note, I've recently start to observe that quality and correctness of log messages slightly, but noticeably increased. So, I guess not much to see here guys, let's move along. :-) ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101231043448.GA92288>