From owner-svn-src-all@FreeBSD.ORG  Wed May 29 11:22:13 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 3E7CFD08;
 Wed, 29 May 2013 11:22:13 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (tensor.andric.com [87.251.56.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 03D0CBD;
 Wed, 29 May 2013 11:22:12 +0000 (UTC)
Received: from spaceball.andric.com (spaceball.andric.com
 [IPv6:2001:7b8:3a7:0:204:4bff:fe01:de8a])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id 9FEE65C44;
 Wed, 29 May 2013 13:22:05 +0200 (CEST)
Message-ID: <51A5E4DE.5060007@FreeBSD.org>
Date: Wed, 29 May 2013 13:22:06 +0200
From: Dimitry Andric <dim@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:22.0) Gecko/20100101 Thunderbird/22.0
MIME-Version: 1.0
To: Adrian Chadd <adrian@FreeBSD.org>, src-committers@freebsd.org, 
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r251098 - head/sys/contrib/dev/ath/ath_hal/ar9300
References: <201305290421.r4T4LgRc099595@svn.freebsd.org>
In-Reply-To: <201305290421.r4T4LgRc099595@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 May 2013 11:22:13 -0000

On 2013-05-29 06:21, Adrian Chadd wrote:
> Author: adrian
> Date: Wed May 29 04:21:42 2013
> New Revision: 251098
> URL: http://svnweb.freebsd.org/changeset/base/251098
>
> Log:
>    Fix a false -> AH_FALSE.
>
>    Now, why this hasn't tripped _any_ tinderbox builds yet, I dunno.
>    It's been like this for a while.

Because 'false' will be implicitly converted to an enum HAL_BOOL value.
Adding a warning for such cases would result in a *lot* of noise, and
probably many angry developers. ;-)

Note that in C++, such a call would result in an error: "no known
conversion from 'bool' to 'HAL_BOOL'".