From owner-freebsd-arch@FreeBSD.ORG Mon Nov 10 09:16:22 2003 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9BD0E16A4CE for ; Mon, 10 Nov 2003 09:16:22 -0800 (PST) Received: from ns1.gnf.org (ns1.gnf.org [63.196.132.67]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E3BD43FCB for ; Mon, 10 Nov 2003 09:16:19 -0800 (PST) (envelope-from gtetlow@gnf.org) Received: from EXCHCLUSTER01.lj.gnf.org (exch01.lj.gnf.org [172.25.10.19]) by ns1.gnf.org (8.12.8p2/8.12.8) with ESMTP id hAAHGILc023438 for ; Mon, 10 Nov 2003 09:16:18 -0800 (PST) (envelope-from gtetlow@gnf.org) Received: from roark.gnf.org ([172.25.24.15]) by EXCHCLUSTER01.lj.gnf.org with Microsoft SMTPSVC(5.0.2195.5329); Mon, 10 Nov 2003 09:16:19 -0800 Received: from roark.gnf.org (localhost [127.0.0.1]) by roark.gnf.org (8.12.10/8.12.10) with ESMTP id hAAHGIvL011346; Mon, 10 Nov 2003 09:16:18 -0800 (PST) (envelope-from gtetlow@gnf.org) Received: (from gtetlow@localhost) by roark.gnf.org (8.12.10/8.12.10/Submit) id hAAHGIUo011345; Mon, 10 Nov 2003 09:16:18 -0800 (PST) (envelope-from gtetlow) Date: Mon, 10 Nov 2003 09:16:18 -0800 From: Gordon Tetlow To: Wes Peters Message-ID: <20031110171618.GD71376@roark.gnf.org> References: <200311041737.20467.wes@softweyr.com> <20031105015709.GC28915@dan.emsphone.com> <20031105081516.GA38016@cirb503493.alcatel.com.au> <200311060943.34284.wes@softweyr.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5l2qnUqb3CiDhrj9" Content-Disposition: inline In-Reply-To: <200311060943.34284.wes@softweyr.com> User-Agent: Mutt/1.4.1i X-Habeas-SWE-1: winter into spring X-Habeas-SWE-2: brightly anticipated X-Habeas-SWE-3: like Habeas SWE (tm) X-Habeas-SWE-4: Copyright 2002 Habeas (tm) X-Habeas-SWE-5: Sender Warranted Email (SWE) (tm). The sender of this X-Habeas-SWE-6: email in exchange for a license for this Habeas X-Habeas-SWE-7: warrant mark warrants that this is a Habeas Compliant X-Habeas-SWE-8: Message (HCM) and not spam. Please report use of this X-Habeas-SWE-9: mark in spam to . X-OriginalArrivalTime: 10 Nov 2003 17:16:19.0183 (UTC) FILETIME=[5B255FF0:01C3A7AE] cc: arch@freebsd.org Subject: Re: newfs and mount vs. half-baked disks X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Nov 2003 17:16:22 -0000 --5l2qnUqb3CiDhrj9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 06, 2003 at 09:43:34AM -0800, Wes Peters wrote: >=20 > I found an unused field called "fs_state" and used that, as Kirk=20 > suggested. Here's the new patch, which changes fsck to notice the=20 > fs_state and doesn't require re-writing all of the superblocks. >=20 > This patch adds a -E (generate errors) option to fsck, causing fsck to=20 > exit at various stages or to otherwise leave the state of fs_state and=20 > fs_clean in other than pristine conditions. I will, of course, commit=20 > the -E changes separately from the fs_state changes. >=20 > Thanks in advance for reviewing. And yes, I did manage to attach the=20 > patch this time. Doh! After a cursory glance, a couple of nits. Perhaps ErrorFlag should be Eflag to be consistent with the style of the rest of the source? Also, your error reporting in fsck_ffs is fs.state !=3D 0 is less than obvious: "superblock %d is not finished" Perhaps it could be "superblock %d is in an inconsistent state, this is probably due to a premature exit of newfs" or some such message. -gordon --5l2qnUqb3CiDhrj9 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (FreeBSD) iD8DBQE/r8fiRu2t9DV9ZfsRAhebAJ98YoH5Bm9ldLenqlWxfXzPriLedQCdH/4U Bam0eoJTWuYZMfT7Lj1c8Sg= =Pqwh -----END PGP SIGNATURE----- --5l2qnUqb3CiDhrj9--