Date: Wed, 5 Sep 2012 22:07:29 -0600 From: Warner Losh <imp@bsdimp.com> To: Aleksandr Rybalko <ray@ddteam.net> Cc: Andrew Turner <andrew@FreeBSD.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r239998 - head/contrib/dtc Message-ID: <1BB2880C-88BA-4918-8C65-6F5E8B0C3058@bsdimp.com> In-Reply-To: <20120902232204.4de5f3a3.ray@ddteam.net> References: <201209020148.q821ml0M018010@svn.freebsd.org> <20120902232204.4de5f3a3.ray@ddteam.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sep 2, 2012, at 2:22 PM, Aleksandr Rybalko wrote: > On Sun, 2 Sep 2012 01:48:47 +0000 (UTC) > Andrew Turner <andrew@FreeBSD.org> wrote: >=20 >> Author: andrew >> Date: Sun Sep 2 01:48:47 2012 >> New Revision: 239998 >> URL: http://svn.freebsd.org/changeset/base/239998 >>=20 >> Log: >> Fix a logic inversion in an assert to allow us to use dts files that >> include other files. >=20 > Big Thanks for that!!! >=20 > It's hard to add overlapping support also? So second instance of same > node will be able to change attributes of previous one, such a = "status". > Or add new attributes, like GPIO lines usage. >=20 > Then we will be able to have per-SoC dts and per-board. =20 Should already be fixed. This is the latest dtc from upstream. Warner >>=20 >> Modified: >> head/contrib/dtc/dtc-lexer.l >>=20 >> Modified: head/contrib/dtc/dtc-lexer.l >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/contrib/dtc/dtc-lexer.l Sat Sep 1 23:33:49 >> 2012 (r239997) +++ head/contrib/dtc/dtc-lexer.l Sun >> Sep 2 01:48:47 2012 (r239998) @@ -198,7 +198,7 @@ static void >> push_input_file(const char * { >> assert(filename); >>=20 >> - assert(include_stack_pointer >=3D MAX_INCLUDE_NESTING); >> + assert(include_stack_pointer < MAX_INCLUDE_NESTING); >>=20 >> srcfile_push(filename); >>=20 >=20 > Thanks. >=20 > WBW > --=20 > Aleksandr Rybalko <ray@ddteam.net>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1BB2880C-88BA-4918-8C65-6F5E8B0C3058>