From owner-cvs-src@FreeBSD.ORG  Thu Apr  3 07:59:41 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1D78C37B401; Thu,  3 Apr 2003 07:59:41 -0800 (PST)
Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4A0F843FA3; Thu,  3 Apr 2003 07:59:40 -0800 (PST)
	(envelope-from obrien@NUXI.com)
Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1])
	by dragon.nuxi.com (8.12.9/8.12.7) with ESMTP id h33FxPD0018009;
	Thu, 3 Apr 2003 07:59:25 -0800 (PST)
	(envelope-from obrien@dragon.nuxi.com)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.12.9/8.12.9/Submit) id h33FxHue018002;
	Thu, 3 Apr 2003 07:59:17 -0800 (PST)
Date: Thu, 3 Apr 2003 07:59:17 -0800
From: "David O'Brien" <obrien@FreeBSD.org>
To: Ruslan Ermilov <ru@FreeBSD.org>
Message-ID: <20030403155917.GC17860@dragon.nuxi.com>
References: <200304030513.h335DR60079544@repoman.freebsd.org>
	<20030402231638.A81523@FreeBSD.org>
	<20030403055049.GA67232@dhcp01.pn.xcllnt.net>
	<20030403180026.A29934@gamplex.bde.org> <20030403085350.GA37174@sunbay.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030403085350.GA37174@sunbay.com>
User-Agent: Mutt/1.4i
X-Operating-System: FreeBSD 5.0-CURRENT
Organization: The NUXI BSD Group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
cc: src-committers@FreeBSD.org
cc: Bruce Evans <bde@zeta.org.au>
cc: Juli Mallett <jmallett@FreeBSD.org>
cc: cvs-src@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: Marcel Moolenaar <marcel@xcllnt.net>
Subject: Re: cvs commit: src/libexec/talkd announce.c extern.h print.c
	table.c talkd.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: obrien@FreeBSD.org
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Apr 2003 15:59:41 -0000

On Thu, Apr 03, 2003 at 11:53:50AM +0300, Ruslan Ermilov wrote:
> -.  if ${WARNS} > 4
> +.  if ${WARNS} > 4 && !empty(CFLAGS:M-O*) && empty(CFLAGS:M-O0)
>  CFLAGS		+=	-Wuninitialized
>  .  endif

Why not just get rid of it totally?  We have this already:

    .  if ${WARNS} > 1 && ${WARNS} < 5
    # XXX Delete -Wuninitialized by default for now -- the compiler doesn't
    # XXX always get it right.
    CFLAGS      +=  -Wno-uninitialized
    .  endif

so we already know it is problematic.  OR rather than use:

    .  if ${WARNS} > 4 
    CFLAGS      +=  -Wuninitialized
    .  endif

use

    .  if ${WARNS} == 4 
    CFLAGS      +=  -Wuninitialized
    .  endif