From owner-freebsd-current Tue Sep 16 09:55:44 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id JAA05365 for current-outgoing; Tue, 16 Sep 1997 09:55:44 -0700 (PDT) Received: from GndRsh.aac.dev.com (GndRsh.aac.dev.com [198.145.92.241] (may be forged)) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id JAA05349 for ; Tue, 16 Sep 1997 09:55:40 -0700 (PDT) Received: (from rgrimes@localhost) by GndRsh.aac.dev.com (8.8.5/8.7.3) id JAA06772; Tue, 16 Sep 1997 09:55:23 -0700 (PDT) From: "Rodney W. Grimes" Message-Id: <199709161655.JAA06772@GndRsh.aac.dev.com> Subject: Re: Make Release Fails... In-Reply-To: <199709160934.TAA26879@godzilla.zeta.org.au> from Bruce Evans at "Sep 16, 97 07:34:45 pm" To: bde@zeta.org.au (Bruce Evans) Date: Tue, 16 Sep 1997 09:55:23 -0700 (PDT) Cc: gurney_j@efn.org, gurney_j@resnet.uoregon.edu, bde@zeta.org.au, freebsd-current@FreeBSD.ORG, Shimon@i-Connect.Net X-Mailer: ELM [version 2.4ME+ PL25 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > >ok.. hear we go.. it turns out that src/include/Makefile isn't recursing > >into the subdirs upon a beforeinstall.. before Bruce explicitately > >wrapped the recursion to limit it to installhdrs.. but now that we > >have switched to beforeinstall to install the files it wasn't recursing.. > > No, it never recursed for beforeinstall. I limited recursion of > installhdrs to that case where installhdrs is being made. > > >how is this one Bruce? I'm testing now, but almost possitive this will > >fix it... > > It may work, but it is bogus. It would have the same effect as putting > everything related back to where it was before rev.1.136 of src/Makefile, > but it takes 10-20 lines of code to subvert the beforeinstall target > and add the installhdrs targets. The problem (of clobbered timestamps) > fixed by rev.1.136 and reintroduced by rev.1.144 is still there. This > can probably be fixed better by setting SHARED=symlinks in the environment > for the call the make includes for buildworld. Bruce, are we in aggreement then that the includes: target should be changed to ``cd {.CURDIR}/include; ${BMAKE} install'', my error was using ``beforeinstall''. And the wrapping the buildworld call to the includes stuff so that it is ``SHARED=symlinks; cd {.CURDIR}/include; make install''. I'd make a cdiff for it, but the test box is in my home office, and I'm in my real office :-(. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation, Inc. Reliable computers for FreeBSD