Date: Sun, 22 Apr 2012 04:29:56 GMT From: Garrett Cooper <yanegomi@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/167191: [PATCH] [bsd.port.mk] fix make package-recursive Message-ID: <201204220429.q3M4Tu2f053098@red.freebsd.org> Resent-Message-ID: <201204220430.q3M4UAt9061770@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 167191
>Category: ports
>Synopsis: [PATCH] [bsd.port.mk] fix make package-recursive
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Apr 22 04:30:10 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Garrett Cooper
>Release: 9.0-RELEASE
>Organization:
EMC Isilon
>Environment:
FreeBSD fuji-9.local 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 UTC 2012 root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
make package-recursive frequently fails because of already installed packages and the fact that check-already-installed fails. The attached patch hacks around the issue (and introduces another problem by not explicitly calling out the package dependency, which could confuse make with -j > 1), but I'm working on a proper (more invasive) change.
>How-To-Repeat:
cd /usr/ports/devel/talloc
make package
make package-recursive
>Fix:
Patch attached with submission follows:
>From acc6b59558b204ef99a1cca3615f5433409b7705 Mon Sep 17 00:00:00 2001
From: Garrett Cooper <yanegomi@gmail.com>
Date: Sat, 21 Apr 2012 18:16:14 -0700
Subject: [PATCH] Make package-recursive work
Signed-off-by: Garrett Cooper <yanegomi@gmail.com>
---
bsd.port.mk | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/bsd.port.mk b/bsd.port.mk
index eee7e3c..984b06a 100644
--- a/Mk/bsd.port.mk
+++ b/Mk/bsd.port.mk
@@ -5488,7 +5488,8 @@ actual-package-depends:
# Build packages for port and dependencies
-package-recursive: package
+package-recursive:
+ @${MAKE} -DFORCE_PKG_REGISTER package
@for dir in $$(${ALL-DEPENDS-LIST}); do \
(cd $$dir; ${MAKE} package-noinstall); \
done
--
1.7.6
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201204220429.q3M4Tu2f053098>