From owner-svn-src-head@freebsd.org  Tue Jan 19 20:52:05 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5D356A89C33;
 Tue, 19 Jan 2016 20:52:05 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 228F21FC5;
 Tue, 19 Jan 2016 20:52:04 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from laptop015.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id E18DC1FE024;
 Tue, 19 Jan 2016 21:52:02 +0100 (CET)
Subject: Re: svn commit: r294327 - in head/sys: dev/cxgb dev/cxgbe dev/e1000
 dev/hyperv/netvsc dev/ixgbe dev/mxge netinet sys
To: Adrian Chadd <adrian.chadd@gmail.com>
References: <201601191533.u0JFXSxf037804@repo.freebsd.org>
 <CAFMmRNz3uXim3H3-sGuBUBs45Jy8p260ywothgp4iFkUcnvnEw@mail.gmail.com>
 <569E6A38.8080108@selasky.org>
 <CAFMmRNx3zC=mz=TC2Aq5==a5vh0Fqzv1domrCL2uUHnjybZSkQ@mail.gmail.com>
 <CAJ-Vmoki0yCU-mmPGfrGyJ_ar_=KKkto_ioomo_Ri_HCWR70cg@mail.gmail.com>
 <569E909B.60506@selasky.org>
 <CAJ-Vmo=1vTmKnoM=wVX=vv99mnkW-Q2CKkxZUNTUBkw_CU6ahQ@mail.gmail.com>
 <569E9B66.1070200@selasky.org>
 <CAJ-Vmo=vi5fdGzx6Z6+D5szrpf0jcaOe7a_9u-o0V7+9YkE6qw@mail.gmail.com>
 <569EA026.5020906@selasky.org>
 <CAJ-VmokCLr7jESQqDYPRUgbo2vQD-1_kC6YhCjqAm3tMz29RUg@mail.gmail.com>
Cc: Ryan Stone <rysto32@gmail.com>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <569EA27B.4050001@selasky.org>
Date: Tue, 19 Jan 2016 21:54:19 +0100
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <CAJ-VmokCLr7jESQqDYPRUgbo2vQD-1_kC6YhCjqAm3tMz29RUg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jan 2016 20:52:05 -0000

On 01/19/16 21:47, Adrian Chadd wrote:
> In this setup you may have the fragments show up at a different hash
> value to the non-fragments, so you'll handle all the non-fragments
> first, then the fragments show up later. So hopefully the LRO code
> handles seeing that hole in the TCP stream and will eject the whole
> stream up.

Yes, the LRO code ejects all fragmented packets. They might be received 
out of order though after the sorting, assuming that's fine.

BTW: I don't see how you can get very high througput with fragmented TCP 
packets w/o LRO.

--HPS